`GLBlitHelperD3D::getD3D11()` does not increment ANGLE device refcount
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
People
(Reporter: ErichDonGubler, Assigned: ErichDonGubler, Mentored)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
While working on 1753349, :jrmuizel, :jgilbert, and I discovered that Firefox has incorrectly foregone increasing the reference count for the D3D device retrieved from ANGLE via QueryDeviceAttribEXT
in GLBlitHelper::GetD3D11()
. The COM pointer returned should have its strong refcount incremented via IUnknown::AddRef
, but it currently does not.
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 1•2 years ago
|
||
Set release status flags based on info from the regressing bug 1322746
Assignee | ||
Comment 2•2 years ago
|
||
Assignee | ||
Comment 3•2 years ago
|
||
A more detailed set of reproduction steps can be found here. Feel free to NI me here if anybody needs support in validating this.
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 5•2 years ago
|
||
The fix for this has landed in autoland
, but it's unclear whether we wish to take additional effort to backport this. NI'ing the folks who will likely be making the call there.
Comment 6•2 years ago
|
||
Bugs get resolved when they're merged to m-c.
Comment 7•2 years ago
|
||
Let's see how things react in Nightly to this change, and if all is well in a few days, then I say patch ESR. It won't be seeing this ANGLE update for a long time.
Comment 8•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Comment 9•2 years ago
|
||
Go ahead and nominate this for ESR approval whenever.
Assignee | ||
Comment 10•2 years ago
|
||
:ryanvm: This patch isn't /quite/ a slam-dunk, since it hasn't been vetted really hard without the ANGLE rebase patches that also landed right after it. So, I'm not sure. Will consult with :jgilbert and :jrmuizel on this one.
Assignee | ||
Comment 11•2 years ago
|
||
:ryanvm: Since this is already in Fx 110, we'd like to see if there's any fall-out before trying to get it into ESR. If Fx 110 goes for a few weeks without there being an apparent regression, we think it'd be worth considering again.
Updated•1 years ago
|
Description
•