Closed Bug 1809352 Opened 2 years ago Closed 2 years ago

Include branding assets for each browser that can be imported from

Categories

(Firefox :: Migration, task, P3)

Desktop
All
task

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: mconley, Assigned: portiawuu, NeedInfo)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

The new migration dialog shows an icon for each browser that can be imported from. The simplest solution to display these is to include the branding in the omni.ja as graphic assets.

This bug tracks the work to both:

  1. Retrieve and package the branding assets to browser/components/migration/content/brands
  2. Update the MigratorBase base class to include a new getter that returns a chrome:// URI string to the appropriate branding asset
Severity: -- → N/A
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → Desktop
Attached file 128x128 browser icon assets (deleted) —
Assignee: nobody → portiawuu

Here's how to approach this bug:

  1. Download and unzip the folder locally. Move the files into a new folder, browser/components/migration/content/brands, and use hg add to add them.
  2. Update the migration component's jar.mn file to make sure we "package" the new images when we build Firefox. You can do that by adding this line:
	content/browser/migration/brands (content/brands/*.png)
  1. Then, let's add a new static key to the MigratorBase class to be overridden by child classes, like this one. Let's call it brandImage or something, and have it return "chrome://global/skin/icons/defaultFavicon.svg" by default.
  2. Update each subclass of MigratorBase to implement that static method, and return a string URL pointing to the appropriate image file. For example, for the SafariProfileMigrator, I think this would be "chrome://browser/content/migration/brands/safari.png".
Attached image 360 icon (128x128) (deleted) —
Attachment #9318027 - Attachment description: Bug 1809352- Include branding assets for each browser that can be imported from. r=mconley,kpatenio,niklas → Bug 1809352- Include branding assets for each browser that can be imported from. r=mconley!,kpatenio!,niklas!
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7d45f0ddbd8b Include branding assets for each browser that can be imported from. r=mconley

Backed out for causing mochitest failures on browser_all_files_referenced.js

Backout link

Push with failures

Failure log

Flags: needinfo?(portiawuu)
Attached image vivaldi.png (deleted) —

Looks like we also missed an icon for Vivaldi, so I'm attaching that here.

Attachment #9318027 - Attachment description: Bug 1809352- Include branding assets for each browser that can be imported from. r=mconley!,kpatenio!,niklas! → Bug 1809352- Include branding assets for each browser that can be imported from. r=mconley,kpatenio,niklas
Attachment #9318027 - Attachment description: Bug 1809352- Include branding assets for each browser that can be imported from. r=mconley,kpatenio,niklas → Bug 1809352- Include branding assets for each browser that can be imported from. r=mconley!,kpatenio!,niklas!
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/41710d48be48 Include branding assets for each browser that can be imported from. r=mconley
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Regressions: 1818498
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: