Closed
Bug 1809695
Opened 2 years ago
Closed 2 years ago
[CTW] Text/Char bounds are 8px fuzzy in nested inline elements
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
112 Branch
Tracking | Status | |
---|---|---|
firefox112 | --- | fixed |
People
(Reporter: morgan, Assigned: morgan)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
See commented out test case in accessible/tests/browser/e10s/browser_caching_text_bounds.js
:)
// XXX: There's a fuzziness here of about 8 pixels, implying we aren't taking into
// account some kind of margin or padding.
// /**
// * Test character bounds in an intervening inline element with margins
// * and with non-br line breaks
// */
// addAccessibleTask(
// `
// <style>
// @font-face {
// font-family: Ahem;
// src: url(${CURRENT_CONTENT_DIR}e10s/fonts/Ahem.sjs);
// }
// </style>
// <div>hello<pre id="t" style="margin-left:100px;margin-top:30px;background-color:blue;">XX
// XXX
// XX
// X</pre></div>`,
// async function(browser, docAcc) {
// await testChar(docAcc, browser, "t", 0);
// await testChar(docAcc, browser, "t", 3);
// await testChar(docAcc, browser, "t", 7);
// await testChar(docAcc, browser, "t", 10);
// },
// {
// chrome: true,
// topLevel: !isWinNoCache,
// iframe: !isWinNoCache,
// }
// );
Updated•2 years ago
|
Blocks: a11y-ctw-text
Severity: -- → S3
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → mreschenberg
Comment 1•2 years ago
|
||
Are we certain this isn't a weird bug in the test harness (rather than the C++ code)? This fails even when running in the parent process (chrome: true with all others false). I guess it's possible we have exactly the same bug in both local and remote, but it's unlikely.
Comment 2•2 years ago
|
||
Could this be because of this?
// test against parent-relative coords, because getBoundingClientRect
// is relative to the document, not the screen. this won't work on nested
// elements (ie. any hypertext whose parent is not the doc).
The HyperText's parent is not the doc in this case because of the <pre>
.
Blocks: 1809761
Assignee | ||
Comment 3•2 years ago
|
||
Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9b60154557d
Make DOM coords screen relative before comparing in testTextRange r=Jamie
Comment 5•2 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox112:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•