Closed Bug 1809758 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 37893 - Fix Servo runner for wdspec tests.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox111 fixed)

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37893 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37893
Details from upstream follow.

Carlos Alberto Lopez Perez <clopez@igalia.com> wrote:

Fix Servo runner for wdspec tests.

  • The Servo test runner for test-type=wdspec was failing due to the the class ServoWdspecBrowser() beeing initialized with unknown arguments See: https://github.com/web-platform-tests/wpt/runs/10514706333

  • Fix it by accepting **kwargs and passing them to the superclass.

  • Also define a default value for webdriver_binary which is needed to avoid an assertion in the main class. In any case the servo runner doesn't use this parameter, but self.binary in the the make_command() function.

//CC @jgraham @gsnedders @jdm

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/17f5b91813af [wpt PR 37893] - Fix Servo runner for wdspec tests., a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/17f5b91813af

Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.