[wpt-sync] Sync PR 37901 - Revert "Initialize long task reporting for ScriptPromiseResolver"
Categories
(Core :: DOM: Performance, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox111 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 37901 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/37901
Details from upstream follow.
Rune Lillesveen <futhark@chromium.org> wrote:
Revert "Initialize long task reporting for ScriptPromiseResolver"
This reverts commit 7943977c5d425843c086abe84c326b7fb4145838.
Reason for revert: Possible culprit for failing longtask-timing tests
See: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110615/overview
Original change's description:
Initialize long task reporting for ScriptPromiseResolver
This tells the PerformanceMonitor to report longtasks
in promise chains that were not started from a callback,
e.g. fetch().then(() => {...long_task})The PerformanceMonitor relies on different probes for "attribution": connecting a long task with one or more frames, to avoid reporting a long task to an unrelated frame tree that happens to be on the same thread.
This design is a bit brittle, as we need to patch through all the things that can invoke a frame-attributed task into PerformanceMonitor.
This CL doesn't attempt to solve this brittleness, in lack of a better solution, but rather to mitigate the particular issue with tasks invoked with a promise, by patching through ScriptPromiseResolver to PerformanceMonitor.
Bug: 1251964
Change-Id: I745780f834f9d1dfc8e8a5c8295326f06276cba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4129480
Commit-Queue: Noam Rosenthal \<nrosenthal@chromium.org>
Reviewed-by: Jeremy Roman \<jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1091706}Bug: 1251964
Change-Id: I2841851f39739cdcc65ca8044115173f97cd88da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161792
Owners-Override: Rune Lillesveen \<futhark@chromium.org>
Commit-Queue: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Auto-Submit: Rune Lillesveen \<futhark@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1091761}
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
Assignee | ||
Comment 3•2 years ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 12 tests and 1 subtests
Status Summary
Firefox
OK
: 10
FAIL
: 13
ERROR
: 2
Chrome
OK
: 12
PASS
: 15
Safari
OK
: 10
FAIL
: 13
ERROR
: 2
Links
Details
New Tests That Don't Pass
- /longtask-timing/buffered-flag.window.html [wpt.fyi]
- PerformanceObserver with buffered flag can see previous longtask entries.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- PerformanceObserver with buffered flag can see previous longtask entries.:
- /longtask-timing/containerNames.html [wpt.fyi]
- Performance longtask entries in iframeWithLongNameMoreThan100CharactersSpaceHolderSpaceHolderSpaceHolderSpaceHolderSpaceHolderSpaceHolder are observable in parent.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Performance longtask entries in iframeWithLongNameMoreThan100CharactersSpaceHolderSpaceHolderSpaceHolderSpaceHolderSpaceHolderSpaceHolder are observable in parent.:
- /longtask-timing/containerTypes.html [wpt.fyi]
- Performance longtask entries in iframe are observable in parent.:
FAIL
(Chrome:PASS
, Safari:FAIL
) - Performance longtask entries in frame are observable in parent.:
FAIL
(Chrome:PASS
, Safari:FAIL
) - Performance longtask entries in object are observable in parent.:
FAIL
(Chrome:PASS
, Safari:FAIL
) - Performance longtask entries in embed are observable in parent.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Performance longtask entries in iframe are observable in parent.:
- /longtask-timing/long-microtask.window.html [wpt.fyi]
- A short task followed by a long microtask is observable.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- A short task followed by a long microtask is observable.:
- /longtask-timing/longtask-attributes.html [wpt.fyi]
- Performance longtask entries are observable.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Performance longtask entries are observable.:
- /longtask-timing/longtask-before-observer.window.html [wpt.fyi]
- PerformanceObserver with buffered flag can see previous longtask entries.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- PerformanceObserver with buffered flag can see previous longtask entries.:
- /longtask-timing/longtask-in-childiframe-crossorigin.html [wpt.fyi]
- Performance longtask entries in cross-origin child iframe are observable in parent.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Performance longtask entries in cross-origin child iframe are observable in parent.:
- /longtask-timing/longtask-in-childiframe.html [wpt.fyi]
- Performance longtask entries in child iframe are observable in parent.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Performance longtask entries in child iframe are observable in parent.:
- /longtask-timing/longtask-in-externalscript.html [wpt.fyi]
- Performance longtask entries are observable.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Performance longtask entries are observable.:
- /longtask-timing/longtask-in-raf.html [wpt.fyi]
- Performance longtask entries are observable.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Performance longtask entries are observable.:
- /longtask-timing/longtask-sync-xhr.html [wpt.fyi]:
ERROR
(Chrome:OK
, Safari:ERROR
) - /longtask-timing/spin-eventloop-not-longtask.html [wpt.fyi]:
ERROR
(Chrome:OK
, Safari:ERROR
)
Comment 5•2 years ago
|
||
bugherder |
Description
•