Rename BrowserTestUtils.loadURI to BrowserTestUtils.loadURIString
Categories
(Testing :: Mochitest, defect)
Tracking
(firefox111 fixed)
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
Attachments
(6 files)
In bug 1810141 we discussed making loadURI take an actual URI and using fixupAndLoadURI for strings, to make it clear what is happening.
One annoying thing is that BrowserTestUtils also has a loadURI API with slightly different params (that takes a string).
I think tests should actually use this API with strings (because they're usually hardcoded and forcing individual tests to make URI instances would be bad dev ergonomics) but they should probably actually not use fixup (because the URIs should be harcoded so we should just try to create the URI).
As a first step to make all these distinctions more explicit, and to make it easier to refactor docshell/webnavigation/browsingcontext's loadURI method, let's rename the BTU method. Because this is reliably called on BrowserTestUtils, this is easy to do automatically.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Comment 3•2 years ago
|
||
Depends on D167150
|
|
Assignee | |
Comment 4•2 years ago
|
||
Depends on D167151
|
|
Assignee | |
Comment 5•2 years ago
|
||
Depends on D167152
|
|
Assignee | |
Comment 6•2 years ago
|
||
Depends on D167153
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/123292be486e
https://hg.mozilla.org/mozilla-central/rev/87e779a95478
https://hg.mozilla.org/mozilla-central/rev/1c487fd7fbe4
https://hg.mozilla.org/mozilla-central/rev/b1e3a79aa45f
https://hg.mozilla.org/mozilla-central/rev/0cc77d71b6b0
Description
•