Closed
Bug 1811049
Opened 2 years ago
Closed 2 years ago
Target.setDiscoverTargets: Support filter option
Categories
(Remote Protocol :: CDP, enhancement, P5)
Tracking
(firefox113 fixed)
RESOLVED
FIXED
113 Branch
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: canadahonk, Assigned: canadahonk)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Implement the filter option for Target.setDiscoverTargets (using base TargetFilter code from Bug 1810812). Happy to work on this also.
|
Assignee | |
Comment 1•2 years ago
|
||
Implement the filter option for Target.setDiscoverTargets, using
internal function created previously. Changed relevant tests as the main
process target (browser type) should NOT be emitted by default. Also had
to change an internal testing function which thought previous was
correct behavior. I have checked with Chromium several times and they
behave the same as with this patch.
Depends on D167172
|
||
Updated•2 years ago
|
Assignee: nobody → oj
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
||
Updated•2 years ago
|
Severity: -- → S3
Priority: -- → P5
|
|
||
Comment 3•2 years ago
|
||
Puppeteer upstream would also need an update to not start failing. The PR can be found at: https://github.com/puppeteer/puppeteer/pull/9693.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df368772785f
[cdp] Implement filter option for Target.setDiscoverTargets r=webdriver-reviewers,whimboo
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•