Closed
Bug 1811130
Opened 2 years ago
Closed 2 years ago
Target.setDiscoverTargets should not emit targetCreated events when ran if discover is false
Categories
(Remote Protocol :: CDP, defect, P5)
Tracking
(firefox114 fixed)
RESOLVED
FIXED
114 Branch
| Tracking | Status | |
|---|---|---|
| firefox114 | --- | fixed |
People
(Reporter: canadahonk, Assigned: canadahonk)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Steps to reproduce:
Call Target.setDiscoverTargets({ discover: false }) in the CDP WebSocket.
Actual results:
Target.targetCreated events are emitted.
Expected results:
Target.targetCreated events should not be emitted when discover is false. Ensured behavior with Chromium.
|
Assignee | |
Comment 1•2 years ago
|
||
To clarify: the events should not be emitted for all valid targets when it is called.
|
|
Assignee | |
Updated•2 years ago
|
Summary: Target.setDiscoverTargets should not emit targetCreated events when discover is false → Target.setDiscoverTargets should not emit targetCreated events when ran if discover is false
|
|
Assignee | |
Comment 2•2 years ago
|
||
Target.setDiscoverTargets should only emit targetCreated events when ran
with discover as true. Ensured this behavior is also matched in
Chromium. A new test is likely unneeded as this seemed like an oversight
with no regression likely possible.
Depends on D167209
|
||
Updated•2 years ago
|
Assignee: nobody → oj
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
||
Updated•2 years ago
|
Severity: -- → S3
Priority: -- → P5
Pushed by oj@oojmed.com:
https://hg.mozilla.org/integration/autoland/rev/19de95401f39
[cdp] Fix Target.setDiscoverTargets emitting targetCreated events with discover false r=webdriver-reviewers,whimboo
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox114:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•