Support relational comparison of {String,BigInt} with null or undefined
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(4 files)
Bug 1810299 was slow due to unsupported comparison ops. Handle the remaining unsupported cases:
- String x {Null, Undefined}
- BigInt x {Null, Undefined}
|
Assignee | |
Comment 1•2 years ago
|
||
This case is already handled by CompareIRGenerator::tryAttachNumber(), which
is called before CompareIRGenerator::tryAttachBoolStringOrNumber().
Also rename the method to tryAttachStringBoolean to match the other String
comparison method tryAttachStringNumber.
|
|
Assignee | |
Comment 2•2 years ago
|
||
Handle String x Boolean in tryAttachStringNumber. Also adds support for String x {Null, Undefined}.
Depends on D167264
|
|
Assignee | |
Comment 3•2 years ago
|
||
This adds support for BigInt x {Null, Undefined} relational comparisons.
Depends on D167265
|
|
Assignee | |
Comment 4•2 years ago
|
||
Depends on D167266
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b6b38d390e21
https://hg.mozilla.org/mozilla-central/rev/b0681205064c
https://hg.mozilla.org/mozilla-central/rev/cf4e8b705023
https://hg.mozilla.org/mozilla-central/rev/5d23be21258f
Description
•