Closed Bug 1811387 Opened 2 years ago Closed 2 years ago

Weather suggestion icon pops in and causes flicker

Categories

(Firefox :: Address Bar, defect, P1)

defect

Tracking

()

VERIFIED FIXED
111 Branch
Tracking Status
firefox111 --- verified
firefox112 --- verified
firefox113 --- verified

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(2 files)

Attached image screenshot (deleted) —

The weather icon can pop in and cause the text to shift. Setting a width and height on the image fixes the text shifting.

Summary: Weather suggestion text pops in and causes flicker → Weather suggestion icon pops in and causes flicker

I didn't realize before now that most of these SVGs have a height of 23 but six
of them have a height of 22.

Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3c28e34398fe Set width and height on weather suggestion icons. r=dao

For QA: In this bug, the weather icon in the weather suggestion pops in a split second after the suggestion is shown and causes the text content of the suggestion to shift to the right (see screenshot). It might help to make a screen recording so you can slow it down. That should not happen anymore. The icon itself may still pop in, but there should be space for it and the text should not shift to the right.

Flags: qe-verify+
Flags: in-testsuite-
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Blocks: 1815018

I have verified this issue on Firefox Release 111.0.1 (Build ID: 20230321111920) on Firefox Beta 112.0b9 (Build ID: 20230330182947) and the latest Nightly 113.0a1 (Build ID: 20230402214746) on Windows 10 x64, macOS 12.4 and Linux Ubuntu 20.04 x64.

  • The icon is displayed correctly, without popping in and without causing the text to shift.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: