Closed Bug 1811507 Opened 2 years ago Closed 2 years ago

The Weather suggestion doesn’t show a background highlight when the result is in a hover, focus or select state

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Version:
Firefox 111
Platform:
Desktop
All
Type:
defect
Points:
3

Tracking

()

Status:
VERIFIED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox109 --- unaffected
firefox110 --- unaffected
firefox111 --- verified

People

(Reporter: cfat, Assigned: dao)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [snt-urlbar-result-menu])

Attachments

(1 file, 1 obsolete file)

Bug 1811507 - Fix highlighting of dynamic type rows. r=adw
(deleted), text/x-phabricator-request
Details

[Affected versions]:

  • Firefox Nightly 111.0a1 - Build ID: 20230120093625

[Affected Platforms]:

  • Windows 10 x64
  • macOS 12.4
  • Linux Ubuntu 20.04 x64

[Prerequisites]:

  • Have Firefox en-US build installed and open.
  • Have a VPN client connected to a US server (for people located outside the US).
  • Have the browser.urlbar.weather.featureGate pref set to true.

[Steps to reproduce]:

  1. Open the browser from the prerequisites.
  2. Open a new tab.
  3. Click inside the Address Bar.
  4. Make sure a Weather result is displayed (repeat previous steps if not).
  5. Hover the cursor over the Weather suggestion.
  6. Observe the behavior.

[Expected result]:

  • The Weather suggestion is highlighted.

[Actual result]:

  • Nothing happens, the Weather suggestion doesn’t show any UI changes.

[Notes]:

  • The background highlight is also missing when focusing the result using the keyboard navigation.
  • Here is a screen recording of the issue: link.

[Regression]:

Keywords: regression
Regressed by: 1801297
Assignee: nobody → mcheang
Status: NEW → ASSIGNED
Attachment #9313365 - Attachment is obsolete: true

Abandoned my patch.

Drew was saying the regression caused other problems besides weather, so we're taking the approach of backing out https://bugzilla.mozilla.org/show_bug.cgi?id=1801297 instead. Then further re-evaluating.

Set release status flags based on info from the regressing bug 1801297

status-firefox-esr102: --- → unaffected
Blocks: urlbar-result-menu
Whiteboard: [snt-urlbar-result-menu]
Attachment #9313365 - Attachment is obsolete: false
Assignee: mcheang → dao+bmo
Points: --- → 2
Priority: -- → P1
Points: 2 → 3
Attachment #9313365 - Attachment is obsolete: true
Attachment #9314003 - Attachment description: WIP: Bug 1811507 - Fix highlighting of dymanic type rows. → Bug 1811507 - Fix highlighting of dymanic type rows. r=adw
Attachment #9314003 - Attachment description: Bug 1811507 - Fix highlighting of dymanic type rows. r=adw → Bug 1811507 - Fix highlighting of dynamic type rows. r=adw
Blocks: 1811870
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/999161f08ecb Fix highlighting of dynamic type rows. r=adw

https://hg.mozilla.org/mozilla-central/rev/999161f08ecb

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox111: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch

I have verified this scenario on the latest Firefox Nightly 111.0a1 (Build ID: 20230129213553) on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.

  • The Weather result is highlighted when in hover (cursor is on top of the result), focus (using keyboard navigation), and select (long click of the result) states.
  • Besides the Default Theme, I also verified the scenario from the Description using Dark and Light Firefox Themes.
Status: RESOLVED → VERIFIED
status-firefox111: fixed → verified
Blocks: 1815018
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: