Closed Bug 1811749 Opened 2 years ago Closed 2 years ago

Investigate if AtomizeString could avoid JSRope::flatten in the cases when the atom is cached

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED DUPLICATE of bug 1808673

People

(Reporter: smaug, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sp3])

Attachments

(1 obsolete file)

Currently AtomizeString always flattens the string and that shows up in the profiles.
https://share.firefox.dev/3whDxUR as an example (from sp2, React-todo).
Could we possible flatten the string only when creating a new atom or something?

This depends on bug 1808673 and whether that proves to be useful or not.

See also bug 1803840 comment 1. Ted, did you try this?

Blocks: 1803803

FWIW, sp2 React-Todo about 1/3 of the strings passed to AtomizeStrings are JSRopes

Priority: -- → P3

Depends on D167490

https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=153068fd9aa8bad14a6ea9b284d6b3eb6027ff43&newProject=try&newRevision=5ba9e4a1533d58bdef6078fba3e0a5bcdb4e92cb
will have some updated numbers. Hopefully jquery won't regress anymore.

React atomizes lots of JSRopes, jQuery lots of linear strings.

Comment on attachment 9314104 [details]
WIP: Bug 1811749, Don't flatten so often in atomize, quick ugly hack

Ended up merging the patches, and the patch is now in bug 1808673

Attachment #9314104 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 2 years ago
Duplicate of bug: 1808673
Resolution: --- → DUPLICATE
Duplicate of this bug: 1803840
Whiteboard: [sp3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: