Closed Bug 1811789 Opened 2 years ago Closed 2 years ago

Assertion failure: MOZ_ASSERT(isString()) at include/js/Value.h:924 with --enable-change-by-array-copy

Categories

(Core :: JavaScript Engine, defect, P3)

defect

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: lukas.bernhard, Assigned: tjc)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Steps to reproduce:

The following sample crashes the js shell in JS::Value::toString when invoked as: ./js --fuzzing-safe --enable-change-array-by-copy crash.js
Not setting s-s because this feature is disabled by default.

function f5() { } 

function f0() {
    const v15 = new Uint8Array();
    f5 &&= v15;
    const v17 = new Uint8Array();
    const v16 = wrapWithProto(v17, f5);
    v16.with();
}
f0();
Component: Untriaged → JavaScript Engine
Product: Firefox → Core

In this call, "TypedArrayWith" needs to be the last parameter, cf. CallSelfHostedNonGenericMethod.

Blocks: 1811054
Severity: -- → S3
Priority: -- → P3

The order of arguments when calling CallTypedArrayMethodIfWrapped() in
the self-hosted TypedArrayWith() function was wrong.

Assignee: nobody → tjc
Attachment #9313902 - Attachment description: WIP: Bug 1811789 - Fix order of arguments in TypedArrayWith() → WIP: Bug 1811789 - Fix order of arguments in TypedArrayWith() r?mgaudet
Status: NEW → ASSIGNED
Attachment #9313902 - Attachment description: WIP: Bug 1811789 - Fix order of arguments in TypedArrayWith() r?mgaudet → Bug 1811789 - Fix order of arguments in TypedArrayWith() r?mgaudet
Pushed by mgaudet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e8e7053a70ea Fix order of arguments in TypedArrayWith() r=mgaudet
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: