Strip tab and newline from Location/URL/<a>/<area>'s protocol setter
Categories
(Core :: DOM: Networking, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | fixed |
People
(Reporter: annevk, Assigned: canadahonk)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Corrected tests: https://github.com/web-platform-tests/wpt/pull/38032.
Context: https://github.com/whatwg/url/issues/609.
|
||
Updated•1 year ago
|
|
Assignee | |
Comment 1•1 year ago
|
||
I believe carriage returns (\r or \0x0D) should be removed as well, looking at WPT tests: https://github.com/web-platform-tests/wpt/blob/master/url/resources/setters_tests.json#L276
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 2•1 year ago
|
||
Strip tabs, new lines, and carriage returns from the input given to
protocol setters for Location, URL, and Link.
Reference: https://github.com/whatwg/url/issues/609
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3b9cc90f1880 Strip certain whitespace from protocol setters r=emilio,necko-reviewers,valentin
|
||
Comment 4•1 year ago
|
||
Backed out for causing wpt failures on url-setters-a-area.window.html.
-
Failure log
Also, some times this crashes first and it's followed by the fail from the above link: https://treeherder.mozilla.org/logviewer?job_id=406582279&repo=autoland&lineNumber=35730
LATER EDIT: there are also failures with this failure lineTEST-UNEXPECTED-FAIL | /html/semantics/scripting-1/the-script-element/execution-timing/108.html | scheduler: javascript URL in iframe - assert_array_equals: expected property 2 to be "iframe script #1" but got "iframe script#1" (expected array ["inline script #1", "inline script #2", "iframe script #1"] got ["inline script #1", "inline script #2", "iframe script#1"])
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/58a9faf47921 Strip certain whitespace from protocol setters r=emilio,necko-reviewers,valentin
|
||
Comment 6•1 year ago
|
||
| bugherder | ||
Description
•