Closed
Bug 18127
Opened 25 years ago
Closed 16 years ago
crash removing broadcast listener from content model
Categories
(Core :: XUL, defect, P2)
Core
XUL
Tracking
()
RESOLVED
WORKSFORME
Future
People
(Reporter: waterson, Unassigned)
References
Details
(Keywords: crash, testcase, Whiteboard: [nsbeta2-][obscure])
Attachments
(1 file, 1 obsolete file)
(deleted),
application/vnd.mozilla.xul+xml
|
Details |
Because broadcast listener nodes are only held by weak reference from the
broadcaster, we will -crash- if:
1. a listener is removed from the content model.
2. all refs are dropped to the listener
3. an attribute changes on the broadcaster
Need to fix nsXULDocument::RemoveSubtreeFromDocument() to deal with this.
Reporter | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P2
Target Milestone: M12
Updated•25 years ago
|
Severity: major → critical
Comment 1•25 years ago
|
||
spam: changing qa contact from ckritzer -> paulmac for xul bugs
Reporter | ||
Updated•25 years ago
|
Target Milestone: M12 → M13
Reporter | ||
Comment 2•25 years ago
|
||
Not critical because no script does this...yet.
Reporter | ||
Comment 3•25 years ago
|
||
Reporter | ||
Comment 4•25 years ago
|
||
attached test case. to reproduce:
1. click on the "test case" link in the bug.
2. open another window (to force the JS GC to run)
3. in the original window, click on the "poke button one" button
Unfortunately, right now, this is not causing a crash because we leak the
buttons :-/. Once I fix the leak, we should see a crash.
Reporter | ||
Updated•25 years ago
|
Priority: P2 → P1
Target Milestone: M13 → M14
Reporter | ||
Comment 5•25 years ago
|
||
Moving the Gordian Knot of 18127, 23905, and 20677 to M14. Fixing this has just
introduced way too many instabilities in my tree that it'll take a couple of
days to sort out. I'll shoot to get these in when M14 opens.
Reporter | ||
Comment 6•25 years ago
|
||
feh
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL. XUL
component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL
Adding "crash" keyword to all known open crasher bugs.
Keywords: crash
Reporter | ||
Comment 9•25 years ago
|
||
This is a design flaw, not visible in current practive. Reducing priority to
reflect this.
Severity: critical → major
Priority: P1 → P2
Updated•25 years ago
|
Summary: [crash] removing broadcast listener from content model → crash removing broadcast listener from content model
Comment 10•25 years ago
|
||
*IGNORE* - massive spam changing open XPToolkit bug's QA contact to
jrgm@netscape.com
QA Contact: paulmac → jrgm
Reporter | ||
Updated•25 years ago
|
Target Milestone: M14 → M15
Reporter | ||
Updated•25 years ago
|
Target Milestone: M15 → M16
Reporter | ||
Comment 12•25 years ago
|
||
you've gotta do some crazy stuff to make this happen. future projects.
Target Milestone: M16 → Future
Comment 13•24 years ago
|
||
Marking [obscure] to separate it from `known' crashers.
Whiteboard: [nsbeta2-] → [nsbeta2-][obscure]
Comment 14•22 years ago
|
||
By the definitions on <http://bugzilla.mozilla.org/bug_status.html#severity> and
<http://bugzilla.mozilla.org/enter_bug.cgi?format=guided>, crashing and dataloss
bugs are of critical or possibly higher severity. Only changing open bugs to
minimize unnecessary spam. Keywords to trigger this would be crash, topcrash,
topcrash+, zt4newcrash, dataloss.
Severity: major → critical
Comment 15•21 years ago
|
||
BTW testcase isn't working (any button isn't visible) with 2003090204/trunk/W2K.
Comment 16•21 years ago
|
||
The testcase link starts download manager.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040316
Comment 17•19 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050905
Firefox/1.6a1
Testcase WFM - No crash.
Comment 18•17 years ago
|
||
If I save the testcase, open a new window, and load it with File > Open File..., I see nothing (no buttons) and there's no crash. So the XUL needs re-work for Firefox 3. The Error Console shows
Error: removeButtonTwo is not defined
Source File: file:///C:/Documents%20and%20Settings/S%20Page/Desktop/Downloads/18127.xul
Line: 1
I'm on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007081905 Minefield/3.0a8pre ID:2007081905
Comment 19•17 years ago
|
||
testcase used obselete tags for gecko 1.9
Here is an updated version
Attachment #4234 -
Attachment is obsolete: true
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
Comment 20•16 years ago
|
||
>testcase rewrotten
WFM on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080818033342 Minefield/3.1a2pre
Comment 21•16 years ago
|
||
->WORKSFORME
Assignee: waterson → nobody
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•