Replace "addon-install-blocked-info" link with moz-support-link
Categories
(Toolkit :: XUL Widgets, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: tgiles, Assigned: tgiles)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [fidefe-reusable-components-ms2])
Attachments
(4 files, 1 obsolete file)
In popup-notifications.inc there is a learn more link that is a SUMO link. We can see this in browser-addons.js, but there is a bit of a tricky situation in this case. This is because the SUMO article chosen is generated dynamically and the text associated with this link comes from a .properties
files and not Fluent.
Also, should this bug be under XUL Widgets or Add-ons Manager?
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
The moz-support-link was initially designed for in-content use.
Since there are places where this component can be used in chrome, we
need to add the ability for this widget to open links when used in the
chrome.
Assignee | ||
Comment 3•2 years ago
|
||
Since we can't synchronously load ESModules yet, we use a new
abstraction of ensureCustomElements to ensure we have access to the
moz-support-link widget in popup-notifications.inc. The previous pattern
of loading the widget via module script does not work in this case due
to browser.xhtml, as we do not want to block on this path.
Depends on D170253
Assignee | ||
Comment 4•2 years ago
|
||
The previous way of setting textContent via string from the
browser.properties file does not work with the moz-support-link widget
since it has a Fluent ID by default. Instead we migrate the existing
string from the browser.properties file to the respective ftl file.
Depends on D170254
Assignee | ||
Comment 5•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Comment 6•2 years ago
|
||
Depends on D170255
Comment 8•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/87bea273fd3a
https://hg.mozilla.org/mozilla-central/rev/eac5effa932d
https://hg.mozilla.org/mozilla-central/rev/beb14240b4e6
https://hg.mozilla.org/mozilla-central/rev/30c52283ff96
Description
•