Closed Bug 1813302 Opened 2 years ago Closed 2 years ago

[Omnibox API] Deletable suggestion result menu is broken

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Version:
Firefox 111
Platform:
x86_64
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- verified
firefox112 --- verified

People

(Reporter: gregp, Assigned: gregp)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [snt-urlbar-result-menu])

Attachments

(2 files)

broken_menu.png
(deleted), image/png
Details
Bug 1813302 - Add missing blockL10n property to UrlbarProviderOmnibox payload r?dao,adw
(deleted), text/x-phabricator-request
Details
Attached image broken_menu.png (deleted) —

Steps to reproduce:

  1. Navigate to about:config
  2. Set browser.urlbar.resultMenu to true
  3. Navigate to https://github.com/gregorypappas/onDeleteSuggestion
  4. Download and unzip the extension
  5. Navigate to about:debugging -> This Firefox -> Temporary Extensions
  6. Select 'Load Extension' and install the unzipped extension from step 4
  7. Type omni 123 in the address bar
  8. Click the result menu button on one of the rows provided by the extension

Actual results:
The menu is empty

Expected results:
The menu is not empty

Assignee: nobody → gp3033
Status: NEW → ASSIGNED
Blocks: urlbar-result-menu
Priority: -- → P1
Whiteboard: [snt-urlbar-result-menu]
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0bd6e56348ff Add missing blockL10n property to UrlbarProviderOmnibox payload r=dao,adw

Thanks, working on it.

Flags: needinfo?(gp3033)
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/406eefb89345 Add missing blockL10n property to UrlbarProviderOmnibox payload r=dao,adw

https://hg.mozilla.org/mozilla-central/rev/406eefb89345

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox111: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch

Hello,

Managed to reproduce the issue with the affected build from 2023-01-28 (20230128211106) using macOS 13.

Confirming this issue as verified fixed with 112.0a1(20230223094032) and 111.0b4(20230221190142) using Windows 11, macOS 13 and Ubuntu22 using the steps from the Description.

Status: RESOLVED → VERIFIED
status-firefox111: fixed → verified
status-firefox112: --- → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: