Closed
Bug 1813476
Opened 2 years ago
Closed 2 years ago
Mass convert all actors to use ES Classes
Categories
(DevTools :: Framework, task)
DevTools
Framework
Tracking
(firefox111 fixed)
RESOLVED
FIXED
111 Branch
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(6 files)
Based on bug 1813475, we can now convert all actors to use ES Classes and extend Actor class.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•2 years ago
|
||
We might followup and remove "echo" which is only used by test?
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
|
Assignee | |
Comment 4•2 years ago
|
||
|
|
Assignee | |
Comment 5•2 years ago
|
||
|
|
Assignee | |
Comment 6•2 years ago
|
||
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6712d3c3b608
[devtools] Ensure instantiating via "new" all actors. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/ddc39bc2aaca
[devtools] Convert RootActor to ES Class. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/2f702a8378d1
[devtools] Convert Thread actor to ES Class. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/92eb19196747
[devtools] Mass migrate all actors from devtools/server/actors/*.js to ES Classes. r=devtools-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/3706a003587b
[devtools] Mass migrate all actors from devtools/server/actors/*/*.js to ES Classes. r=devtools-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/758bd74e8beb
[devtools] Convert a few non-actor code to ES Classes. r=devtools-reviewers,nchevobbe
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6712d3c3b608
https://hg.mozilla.org/mozilla-central/rev/ddc39bc2aaca
https://hg.mozilla.org/mozilla-central/rev/2f702a8378d1
https://hg.mozilla.org/mozilla-central/rev/92eb19196747
https://hg.mozilla.org/mozilla-central/rev/3706a003587b
https://hg.mozilla.org/mozilla-central/rev/758bd74e8beb
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox111:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
|
||
Comment 9•2 years ago
|
||
== Change summary for alert #36875 (as of Wed, 01 Feb 2023 05:03:44 GMT) ==
Regressions:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 23% | damp console.log-in-loop-content-process-node | linux1804-64-shippable-qr | e10s fission stylo webrender | 41.75 -> 51.25 |
| 20% | damp console.log-in-loop-content-process-node | linux1804-64-shippable-qr | e10s fission stylo webrender-sw | 41.68 -> 50.13 |
| 14% | damp console.log-in-loop-content-process-promise | linux1804-64-shippable-qr | e10s fission stylo webrender-sw | 61.00 -> 69.68 |
| 14% | damp console.log-in-loop-content-process-promise | linux1804-64-shippable-qr | e10s fission stylo webrender | 61.30 -> 69.95 |
| 13% | reload-inspector:content-process objects-with-stacks | linux1804-64-tsan-qr | 3,986.33 -> 4,511.00 | |
| 13% | reload-inspector:content-process objects-with-stacks | linux1804-64-qr | 3,989.64 -> 4,513.75 | |
| 13% | reload-inspector:content-process objects-with-stacks | linux1804-64-shippable-qr | 3,991.58 -> 4,514.67 | |
| 11% | damp complicated.jsdebugger.close.DAMP | macosx1015-64-shippable-qr | e10s fission stylo webrender-sw | 23.82 -> 26.50 |
| 7% | damp console.log-in-loop-content-process-date | linux1804-64-shippable-qr | e10s fission stylo webrender-sw | 61.91 -> 66.13 |
| 6% | damp console.log-in-loop-content-process-longstring | macosx1015-64-shippable-qr | e10s fission stylo webrender-sw | 47.51 -> 50.52 |
| ... | ... | ... | ... | ... |
| 4% | reload-debugger:content-process objects-with-stacks | linux1804-64-tsan-qr | 967.08 -> 1,009.00 | |
| 4% | reload-netmonitor:content-process objects-with-stacks | linux1804-64-tsan-qr | 1,011.29 -> 1,053.00 | |
| 4% | damp console.log-in-loop-content-process-bool | windows10-64-shippable-qr | e10s fission stylo webrender | 47.76 -> 49.48 |
| 3% | damp console.log-in-loop-content-process-undefined | windows10-64-shippable-qr | e10s fission stylo webrender | 48.92 -> 50.33 |
| 2% | damp console.log-in-loop-content-process-object | macosx1015-64-shippable-qr | e10s fission stylo webrender-sw | 226.74 -> 231.58 |
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 1335% | reload-debugger:content-process objects-with-no-stacks | linux1804-64-tsan-qr | 8.58 -> -106.00 | |
| 346% | reload-netmonitor:content-process objects-with-no-stacks | linux1804-64-shippable-qr | 32.21 -> -79.25 | |
| 325% | reload-netmonitor:content-process objects-with-no-stacks | linux1804-64-qr | 35.08 -> -78.92 | |
| 252% | reload-netmonitor:content-process objects-with-no-stacks | linux1804-64-tsan-qr | 45.79 -> -69.50 | |
| 8% | reload-no-devtools:content-process objects-with-no-stacks | linux1804-64-tsan-qr | 52.00 -> 48.00 | |
| ... | ... | ... | ... | ... |
| 2% | browser-console:parent-process objects-with-stacks | linux1804-64-tsan-qr | 16,526.00 -> 16,162.33 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=36875
You need to log in
before you can comment on or make changes to this bug.
Description
•