Closed
Bug 1813809
Opened 2 years ago
Closed 2 years ago
Implement safeguard for Feature Callout pref getter function
Categories
(Firefox :: Messaging System, enhancement, P2)
Firefox
Messaging System
Tracking
()
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: jprickett, Assigned: halemu)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
When a feature callout pref is changed to a value that can't safely be JSON.parsed, it causes an error that can freeze a tab if the callout is used in chrome. The custom function in the featureTourProgress
pref getter should be bolstered to implement a safeguard to prevent this error from freezing a tab in this scenario.
Reporter | ||
Comment 1•2 years ago
|
||
To manually reproduce this issue, you can try the following steps:
- update the browser.pdfjs.feature-tour to
{"screen":"FEATURE_CALLOUT_1_A","complete":false}
- In a new tab, navigate to any pdf file and observe the feature callout appear
- Tab back over to
about:config
and update that pref to be something that is not parsable JSON (so a string or basically anything that's not an object should do) and try to go back to the PDF tab. The active tab will not change to the PDF tab.
Updated•2 years ago
|
Attachment #9321730 -
Attachment description: WIP: Bug 1813809 - Implement safeguard for Feature Callout pref getter function → Bug 1813809 - Implement safeguard for Feature Callout pref getter function r=#omc-reviewers
Updated•2 years ago
|
Attachment #9319541 -
Attachment is obsolete: true
Updated•2 years ago
|
Iteration: 112.2 - Feb 27 - Mar 10 → 113.1 - Mar 13 - Mar 24
Pushed by halemu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57b39eab6460
Implement safeguard for Feature Callout pref getter function r=omc-reviewers,aminomancer
Comment 5•2 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: 111 Branch → 113 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•