Closed
Bug 1814659
Opened 2 years ago
Closed 2 years ago
DoH native fallback warning should not show after switching to a non-restricted network
Categories
(Firefox :: Security, defect, P2)
Tracking
()
RESOLVED
FIXED
112 Branch
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | fixed |
People
(Reporter: acreskey, Assigned: acreskey)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
When testing the network.trr.display_fallback_warning option on a DoH-restricted network, I correctly see the native fallback warning. But when change networks to a non-restricted one, I'm still seeing the native fallback warning.
|
Assignee | |
Comment 1•2 years ago
|
||
What I'm seeing is that while we correctly re-run heuristics after a network change, the canary heuristic still fails until Firefox relaunches.
The canary dns lookup is made with cache disabled so figuring that out now.
|
|
Assignee | |
Comment 2•2 years ago
|
||
It's not correct to fail name lookups when they are made in TRR_DISABLED_MODE.
In the case of the bug, the canary lookup after switching networks was being failed by the native fallback warning logic.
Pushed by acreskey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57f2c2b10b32
DoH native fallback warning should not show after switching to a non-restricted network r=valentin,necko-reviewers
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox112:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•