Closed
Bug 1814732
Opened 2 years ago
Closed 2 years ago
Move weather suggestions to their own provider
Categories
(Firefox :: Address Bar, task, P1)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
111 Branch
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
In preparation for keyword-based weather suggestions, it would be helpful to move them to their own provider.
|
Assignee | |
Comment 1•2 years ago
|
||
This moves weather suggestions from the quick suggest provider to their own
provider. This will make it easier to implement weather suggestions that are
triggered by keyword instead of being shown on zero-prefix.
It does the following:
- Copies UrlbarProviderQuickSuggest.sys.mjs to UrlbarProviderWeather.sys.mjs
- Removes everything weather-related from UrlbarProviderQuickSuggest.sys.mjs
- Removes everything not weather-related from UrlbarProviderWeather.sys.mjs
- Makes some simplifications to the new provider since it doesn't need to
support quick suggest suggestions - Removes
result.payload.isWeathersince now we can useresult.providerName - This does not change any telemetry
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0b6edbb179a
Move weather suggestions to their own provider. r=daisuke
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox111:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
|
|
Assignee | |
Updated•2 years ago
|
Flags: qe-verify-
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•