Closed Bug 1814830 Opened 2 years ago Closed 2 years ago

Don't use side-effect free Debugger for custom formatters

Categories

(DevTools :: Framework, task)

task

Tracking

(firefox111 fixed)

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

While adding support for CLJS custom formatters, we constantly bumped into issues with the requirement we set that custom formatters hook need to be side-effect free; CLJS implementation could avoid having side effect, but even with that, we're seeing other issues like Bug 1809613.
As this feature is behind a pref (even 2 at the moment), and given that Chrome doesn't have such requirement, let's use a regular debugger to call the hooks.
The whole feature will go through security review before shipping so we should be safe.
We might have some extra UI to make it more safe (displaying some notification when custom formatters are being used, having some kind of per-domain premission, …)

We can always revisit this in the future if we find that we can handle this with side-effect free debugger

Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/138713ec3f6d [devtools] Drop side-effect free requirement for custom formatter hooks. r=ochameau.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: