Release geckodriver 0.32.2 with marionette 0.3.0 ("cargo install geckodriver" is broken for 0.31.0 and 0.32.0 releases)
Categories
(Testing :: geckodriver, defect, P1)
Tracking
(firefox111 fixed)
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [webdriver:m6])
Attachments
(3 files)
As reported on Matrix by khuey geckodriver cannot be build anymore for the 0.31.0 and 0.32.0 releases via cargo install. The following command will fail:
cargo install --version 0.31.0 geckodriver
The reason is the change from bug 1811996 and that we did a semver incompatible version bump for the Marionette crate when releasing geckodriver 0.32.1 via bug 1794560.
error: could not compile `geckodriver` due to 9 previous errors
error: failed to compile `geckodriver v0.32.0`, intermediate artifacts can be found at `/var/folders/sd/hgkqcwv90sz_q1pqjww78nfm0000gn/T/cargo-install55mx5A`
We should decide what to do here. Most likely we should yank the marionette 0.2.1 crate and geckodriver 0.31.1 after releasing a new 0.31.2 release.
Lets discuss on Monday in our triage meeting.
|
Assignee | |
Comment 1•2 years ago
|
||
To prevent such regressions we could run cargo semver-checks check-release for each of the dependency crates as part of Update in-tree dependency crates. The tool needs to be installed once via cargo install cargo-semver-checks --locked (website).
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 2•2 years ago
|
||
The release of version 0.2.1 didn't obey the semver rules and
introduced a backward incompatible bug. As such we have to
release a minor release now.
|
|
Assignee | |
Comment 3•2 years ago
|
||
Depends on D168984
|
|
Assignee | |
Comment 4•2 years ago
|
||
Depends on D168985
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 7•2 years ago
|
||
The merge to mozilla-central was done as part of 602aa16c20d4.
Once all the signed geckodriver builds are ready I will do the release.
|
|
Assignee | |
Comment 9•2 years ago
|
||
Upstream import: https://github.com/mozilla/geckodriver/pull/2083
Version v0.32.2 is released: https://github.com/mozilla/geckodriver/releases/tag/v0.32.2
Crates have been published to crates.io:
Uploading marionette v0.3.0
Uploading geckodriver v0.32.2
Next step is to yank the broken crates from crates.io and to check that everything builds fine again.
|
|
Assignee | |
Comment 10•2 years ago
|
||
Yanked the following crates:
Made the announcement on the mailing list:
https://groups.google.com/a/mozilla.org/g/dev-webdriver/c/XXN5L8JptEk
I'm going to leave the bug open until the remaining commit got merged to mozilla-central.
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 11•2 years ago
|
||
| bugherder | ||
Description
•