Closed
Bug 1814912
Opened 2 years ago
Closed 2 years ago
Try using HTML5 <dialog> element to wrap the MigrationWizard when embedded in about:preferences
Categories
(Firefox :: Migration, task, P1)
Firefox
Migration
Tracking
()
RESOLVED
FIXED
111 Branch
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
We're currently using the SubDialog library at https://searchfox.org/mozilla-central/rev/2d820afafbe62b0148e2766a4d371556edefe36f/toolkit/modules/SubDialog.sys.mjs to show the MigrationWizard in about:preferences.
Considering that we're already veering away from using the default SubDialog styles (bug 1814437), and the fact that we're doing some hand-rolled handling of Escape to dismiss the dialog, and also some weird things to keep it sized correctly, it might be worth investigating whether or not we can host the MigrationWizard in an HTML5 <dialog> element in about:preferences rather than using gSubDialog and migration-dialog.html.
|
||
Updated•2 years ago
|
Severity: -- → N/A
Priority: -- → P3
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → mconley
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Updated•2 years ago
|
Priority: P3 → P1
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b96a7f177208
Use an HTML5 dialog instead of gSubDialog for the new migration wizard in about:preferences. r=Gijs,settings-reviewers
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox111:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•