Closed Bug 1815396 Opened 2 years ago Closed 2 years ago

Proxx-Tables-Canvas is very CSS parsing heavy (and some shows up in React-Stockcharts too)

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: smaug, Assigned: emilio)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sp3])

Attachments

(2 files)

Bug 1815396 - Fix documentation of MruCache. r=lsalzman,jfkthame,nika
(deleted), text/x-phabricator-request
Details
Bug 1815396 - Add an MruCache for ParseColor, just like we have for fonts. r=jfkthame,#gfx-reviewers
(deleted), text/x-phabricator-request
Details

https://share.firefox.dev/3X4muR2

Looks like it is mostly about parsing colors.
Would it possibly work to have a cache somewhere?

Also in React-Stockcharts
https://share.firefox.dev/3SOS8RO

Summary: Proxx-Tables-Canvas is very CSS parsing heavy → Proxx-Tables-Canvas is very CSS parsing heavy (and some shows up in React-Stockcharts too)

Could you perhaps try to find someone to take a look at this?
Maybe a cache similar to the font cache could work here, I mean in mozilla::dom::CanvasRenderingContext2D::ParseColor?

Flags: needinfo?(emilio)
Assignee: nobody → emilio
Status: NEW → ASSIGNED

Since currentColor usage is expected to be ~0, don't make the restyle
generation etc part of the cache.

Depends on D171653

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0fb8dd16d01c Fix documentation of MruCache. r=lsalzman https://hg.mozilla.org/integration/autoland/rev/68e805821a98 Add an MruCache for ParseColor, just like we have for fonts. r=gfx-reviewers,lsalzman

Backed out 2 changesets (Bug 1815396) for wpt failures on 2d.gradient.object.current.html.
Backout link
Push with failures <--> wpt5
Failure Log

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9623cdb18bcb Fix documentation of MruCache. r=lsalzman https://hg.mozilla.org/integration/autoland/rev/e2253a9a6cf6 Add an MruCache for ParseColor, just like we have for fonts. r=gfx-reviewers,lsalzman
Flags: needinfo?(emilio)

https://hg.mozilla.org/mozilla-central/rev/9623cdb18bcb
https://hg.mozilla.org/mozilla-central/rev/e2253a9a6cf6

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Whiteboard: [sp3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: