Closed
Bug 1816182
Opened 2 years ago
Closed 2 years ago
Stop applying ESLint test configuration to module files
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox112 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(2 files)
When module files are in test directories, we apply the configurations to them regardless. This means that they can get the wrong globals applied.
I think we should therefore exclude them from the test configurations. There are some rules that may not get applied, but I think generally it is only mozilla/no-arbitrary-setTimeout and @microsoft/sdl/no-insecure-url that would not get applied, and I think that is reasonable for test module files.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Comment 3•2 years ago
|
||
bug 1675349 removed the one consumer of BlocklistTestProxy being removed here.
Depends on: 1675349
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bf1c189a9e28 Remove unused BlocklistTestProxy. r=Gijs https://hg.mozilla.org/integration/autoland/rev/69b339baa090 Stop applying ESLint test configuration to module files. r=Gijs,necko-reviewers
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bf1c189a9e28
https://hg.mozilla.org/mozilla-central/rev/69b339baa090
You need to log in
before you can comment on or make changes to this bug.
Description
•