Closed Bug 1816807 Opened 2 years ago Closed 2 years ago

Thread-pane + message pane intermittently do not match (after navigating to next unread)

Categories

(Thunderbird :: Folder and Message Lists, defect)

Thunderbird 111
defect

Tracking

(thunderbird_esr102 unaffected, thunderbird111 fixed)

RESOLVED FIXED
112 Branch
Tracking Status
thunderbird_esr102 --- unaffected
thunderbird111 --- fixed

People

(Reporter: mkmelin, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [Supernova3p])

Attachments

(3 files)

Thread-pane + message pane intermittently do not match: especially after navigating (N to next unread) to something that wasn't in view.
I'm not sure if it's the list selection that changes (afterwards) into something wrong, or the wrong message gets shown.

Yes, the message pane seems to be changing itself only. I've got a number of issues to do with navigating that I'll fix at the same time.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
  • Stops the message pane navigating by itself without updating the thread pane
  • When switching folders, waits for the folder to load before selecting a message
  • Handles message selection better

Invalidating too many times is causing problems with navigating to the next message, and with restoring the sort order.

Depends on D170307

This isn't intended to be a complete test. I'll come back to it and add the remaining navigation actions later.

Keywords: leave-open
Target Milestone: --- → 112 Branch
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/54708e32db90 Prevent unnecessary thread tree invalidation when changing folders. r=mkmelin https://hg.mozilla.org/comm-central/rev/0a0e79151c91 Fix multiple issues navigating to the next message. r=mkmelin
Attachment #9318844 - Flags: approval-comm-beta?
Attachment #9319116 - Flags: approval-comm-beta?
Keywords: leave-open

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/476d3792e1f0
follow-up - Fix broken tests. rs=bustage-fix DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/8c3dfe39d2d4
Test navigation to the next [unread] message. r=mkmelin

Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED

(In reply to Pulsebot from comment #7)

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/8c3dfe39d2d4
Test navigation to the next [unread] message. r=mkmelin

you want this also on beta?

Flags: needinfo?(mkmelin+mozilla)

Comment on attachment 9318844 [details]
Bug 1816807 - Fix multiple issues navigating to the next message. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9318844 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9319116 [details]
Bug 1816807 - Prevent unnecessary thread tree invalidation when changing folders. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9319116 - Flags: approval-comm-beta? → approval-comm-beta+

(In reply to Wayne Mery (:wsmwk) from comment #8)

you want this also on beta?

Yes I do. And note to whoever's uplifting stuff, there was a bustage fix in this bug also. I screwed up. :-(

Flags: needinfo?(mkmelin+mozilla)
Attachment #9319120 - Flags: approval-comm-beta?

Comment on attachment 9319120 [details]
Bug 1816807 - Test navigation to the next [unread] message. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta
(already uplifted)

Attachment #9319120 - Flags: approval-comm-beta? → approval-comm-beta+

(In reply to Wayne Mery (:wsmwk) from comment #13)

(already uplifted)

It wasn't. Please uplift this patch.

Flags: needinfo?(daniel)
Flags: needinfo?(daniel)
Whiteboard: [Supernova] → [Supernova3p]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: