Closed
Bug 1816901
Opened 2 years ago
Closed 1 year ago
Stop using promiseItemId in product code
Categories
(Toolkit :: Places, task, P3)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
116 Branch
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
promiseItemGUID is only used in testing code, it should be possible to do the same for promiseItemId, with some small refactoring of gEditItemOverlay and using RETURNING on some queries.
What'd be left then is promiseManyItemIds, before the whole GuidHelper can be moved to testing code. that may likely also be removed with some changes to Bookmarks.jsm (it's unlikely we can completely remove itemIds but at least we could fetch them while we fetch other data).
|
Assignee | |
Updated•1 year ago
|
Assignee: nobody → mak
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•1 year ago
|
||
|
|
Assignee | |
Comment 2•1 year ago
|
||
Depends on D180410
|
|
Assignee | |
Comment 3•1 year ago
|
||
Depends on D180411
|
||
Updated•1 year ago
|
Attachment #9338223 -
Attachment description: WIP: Bug 1816901 - Stop using promiseItemId in product code. → Bug 1816901 - Stop using promiseItemId in product code. r=daisuke
|
|
||
Updated•1 year ago
|
Attachment #9338224 -
Attachment description: WIP: Bug 1816901 - Stop using promiseManyItemdIds in product code. → Bug 1816901 - Stop using promiseManyItemdIds in product code. r=daisuke
|
|
||
Updated•1 year ago
|
Attachment #9338225 -
Attachment description: WIP: Bug 1816901 - Remove the Places GuidHelper. → Bug 1816901 - Remove the Places GuidHelper. r=daisuke
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/3589e6b5cd09
Stop using promiseItemId in product code. r=daisuke
https://hg.mozilla.org/integration/autoland/rev/47c72bd9e7ec
Stop using promiseManyItemdIds in product code. r=daisuke
https://hg.mozilla.org/integration/autoland/rev/c07120b42e96
Remove the Places GuidHelper. r=daisuke,sync-reviewers,skhamis
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3589e6b5cd09
https://hg.mozilla.org/mozilla-central/rev/47c72bd9e7ec
https://hg.mozilla.org/mozilla-central/rev/c07120b42e96
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox116:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•