Closed
Bug 1817036
Opened 2 years ago
Closed 2 years ago
Remove osfile usage from devtools pt 2
Categories
(DevTools :: General, task, P1)
DevTools
General
Tracking
(firefox112 fixed)
RESOLVED
FIXED
112 Branch
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | fixed |
People
(Reporter: barret, Assigned: barret)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
An instance was missed because it wasnt using osfile.jsm directly: https://searchfox.org/mozilla-central/rev/84fb1c4511312a0b9187f647d90059e3a6dd27f8/devtools/shared/loader/base-loader.sys.mjs#15
And a new instance was introduced: https://searchfox.org/mozilla-central/source/devtools/shared/heapsnapshot/tests/xpcshell/test_ReadHeapSnapshot_with_utf8_paths.js
|
Assignee | |
Comment 1•2 years ago
|
||
The implementation of base-loader operates on stringly-typed URIs with path
methods. Refactoring this module to use paths and URIs is beyond the scope of
removing OS.File, so the methods from ospath_unix.jsm have been copied into the
module.
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fabb850d6db8
Remove osfile.jsm and ospath.jsm usage from devtools/ r=ochameau
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox112:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•