Closed
Bug 1817183
Opened 2 years ago
Closed 2 years ago
Convert most of services/fxaccounts to ES modules
Categories
(Firefox :: Firefox Accounts, task)
Firefox
Firefox Accounts
Tracking
()
RESOLVED
FIXED
112 Branch
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
(Whiteboard: [esmification-timeline])
Attachments
(2 files)
These patches will convert all of services/fxaccounts, except FxAccountsCommon.js which will need more manual work.
Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=bca4031cf2da5da46e2a424ee96ff158cb93ce5f
|
Assignee | |
Comment 1•2 years ago
|
||
Depends on D170060
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D170061
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cfed8d9c23f3
Migrate most of services/fxaccounts to ES modules. r=markh
https://hg.mozilla.org/integration/autoland/rev/17d4c013ed92
Update consumers of services/fxaccounts to import ES modules directly. r=markh,settings-reviewers,credential-management-reviewers,sgalich
|
||
Comment 4•2 years ago
|
||
Backed out for causing dt failures in browser_jsterm_autocomplete_null.js
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_null.js | Got error "ReferenceError: URI is not defined init resource://services-settings/remote-settings.sys.mjs:579 RemoteSettingsInit resource:///modules/BrowserGlue.sys.mjs:2963 _scheduleBestEffortUserIdleTasks resource:///modules/BrowserGlue.sys.mjs:3018 ChromeUtils::IdleDispatch handler*_scheduleBestEffortUserIdleTasks resource:///mo
Flags: needinfo?(standard8)
|
|
Assignee | |
Updated•2 years ago
|
Flags: needinfo?(standard8)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ed8526533ab
Migrate most of services/fxaccounts to ES modules. r=markh
https://hg.mozilla.org/integration/autoland/rev/0eeaa0fcd9a3
Update consumers of services/fxaccounts to import ES modules directly. r=markh,settings-reviewers,credential-management-reviewers,sgalich
|
|
Assignee | |
Comment 6•2 years ago
|
||
FTR I filed a PR to update FxAccountPairingChannel on the github repo: https://github.com/mozilla/fxa-pairing-channel/pull/82
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7ed8526533ab
https://hg.mozilla.org/mozilla-central/rev/0eeaa0fcd9a3
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox112:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
|
||
Updated•2 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•