Closed Bug 1817196 Opened 2 years ago Closed 2 years ago

Disabling top sites or setting maxRichResults to 0 is returning empty results set

Categories

(Firefox :: Address Bar, defect, P2)

defect

Tracking

()

VERIFIED FIXED
112 Branch
Tracking Status
firefox112 --- verified

People

(Reporter: mak, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

It is expected that we return empty result sets, but we currently have no insight into that.
We need either to report the preferences status in environment, or add an environment property in each event, so we can cross check user settings that may influence the events.
This is something we must coordinate with Glean team.

There's a chat log with Chutten in our working document. He suggested for now to add primitive metrics for the preferences directly to the events ping using

send_in_pings:
    - events
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e7a8fb56745e Record preference value that affects the number of results showing in the urlbar r=mak
Attached file data-review-request-for-bug1817196.md (deleted) —
Attachment #9320217 - Flags: data-review?(mmccorquodale)

Backed out as requested by dev for missing data-review.

Flags: needinfo?(daisuke)

Comment on attachment 9320217 [details]
data-review-request-for-bug1817196.md

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes. this is recorded in the Glean dictionary.

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, users can opt out of telemetry collection.

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?
    The search and suggest team.

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    Category 2, interaction data.

  5. Is the data collection request for default-on or default-off?
    Default on.

  6. Does the instrumentation include the addition of any new identifiers?
    No new identifiers.

  7. Is the data collection covered by the existing Firefox privacy notice?
    Yes.

  8. Does the data collection use a third-party collection tool?
    No.


data-review +

Attachment #9320217 - Flags: data-review?(mmccorquodale) → data-review+
Flags: needinfo?(daisuke)
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c733c7c9b79a Record preference value that affects the number of results showing in the urlbar r=mak
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch

Hey Marco,
Could you please provide some steps in order to verify this?

Flags: needinfo?(mak)

(In reply to Cristian Baica [:cbaica], Release Desktop QA from comment #9)

Hey Marco,
Could you please provide some steps in order to verify this?

The thing to verify here is that the Glean event ping includes the 2 new metrics:
pref_max_results (quantity metric) should report the value of browser.urlbar.maxRichResult
pref_suggest_topsites (boolean metric) sould report the value of browser.urlbar.suggest.topsites

Flags: needinfo?(mak)

The issue is verified fixed in the latest Fx 112.0a1 on Windows 10 and Ubuntu 22.04. The pref values are correctly displayed after pulling them from the browser console using: "Glean.urlbar.prefMaxResults.testGetValue()" and "Glean.urlbar.prefSuggestTopsites.testGetValue()".
Please note that I could not find the values in a metrics ping sent to glean.

Status: RESOLVED → VERIFIED

I see those metrics in Redash, so it should be good.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: