Closed Bug 1817419 Opened 2 years ago Closed 2 years ago

Crash in [@ do_QueryFrameHelper<T>::FastQueryFrame<T>::QueryFrame]

Categories

(Core :: Widget: Gtk, defect)

Unspecified
Linux
defect

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox110 --- wontfix
firefox111 --- fixed
firefox112 --- fixed

People

(Reporter: gsvelto, Assigned: stransky)

References

(Regression)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

Crash report: https://crash-stats.mozilla.org/report/index/918457bc-3899-4f28-8d5a-3710b0230217

Reason: SIGSEGV / SEGV_MAPERR

Top 10 frames of crashing thread:

0  libxul.so  do_QueryFrameHelper<nsIFrame>::FastQueryFrame<nsIFrame, nsMenuPopupFrame, void, void>::QueryFrame  /build/firefox/src/firefox-110.0/layout/generic/nsQueryFrame.h:131
0  libxul.so  do_QueryFrameHelper<nsIFrame>::operator nsMenuPopupFrame*<nsMenuPopupFrame>  /build/firefox/src/firefox-110.0/layout/generic/nsQueryFrame.h:107
0  libxul.so  mozilla::dom::XULPopupElement::IsWaylandDragSource const  /build/firefox/src/firefox-110.0/dom/xul/XULPopupElement.cpp:323
1  libxul.so  mozilla::dom::XULPopupElement_Binding::get_isWaylandDragSource  s3:gecko-generated-sources-l1:2d69ca3a83743b1747b10bcc351a43b617cc447c1904d2725e07fdba2e17905c588bf0a854c991c6f839c81a6f487bdd22f61ce9dd3e17a349a2a65c8daa4f2b/dom/bindings/XULPopupElementBinding.cpp::1691
2  libxul.so  mozilla::dom::binding_detail::GenericGetter<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>  /build/firefox/src/firefox-110.0/dom/bindings/BindingUtils.cpp:3190
3  libxul.so  CallJSNative  /build/firefox/src/firefox-110.0/js/src/vm/Interpreter.cpp:459
3  libxul.so  js::InternalCallOrConstruct  /build/firefox/src/firefox-110.0/js/src/vm/Interpreter.cpp:547
3  libxul.so  InternalCall  /build/firefox/src/firefox-110.0/js/src/vm/Interpreter.cpp:614
3  libxul.so  js::Call  /build/firefox/src/firefox-110.0/js/src/vm/Interpreter.cpp:646
3  libxul.so  js::CallGetter  /build/firefox/src/firefox-110.0/js/src/vm/Interpreter.cpp:768

Several comments in the crash reports mentioning that this happens while moving around bookmarks:

I was organising bookmarks in my bookmarks bar because I have a lot. The overflow menu was open and from there I grabbed the "Most used" automatic folder to drag it to the first place in the bookmarks bar for easy access. I had to pause for a second as I moved the mouse because the laptop touchpad didn't let me reach all the way. The dragged "Most used" bookmark ended up dangling somewhere in the area of the address bar for a second and the browser crashed right before it would've done the animation to visualise that the URL in hand can be opened there.

Was moving a toolbar shortcut.

When dragging a bookmark from the >> tab into the bookmark toolbar I crash.

I was dragging a site's address into a third level subdirectory of the link library, then always crashing at the second level.

The crashes I've inspected all have the IsWayland annotation set to 0.

Assignee: nobody → stransky
Status: NEW → ASSIGNED
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/983ae0fe504a [Linux] Make XULPopupElement::IsWaylandDragSource() more robust r=emilio
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox111 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(stransky)

Comment on attachment 9318405 [details]
Bug 1817419 [Linux] Make XULPopupElement::IsWaylandDragSource() more robust r?emilio

Beta/Release Uplift Approval Request

  • User impact if declined: Possible browse crash during D&D on Linux.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Added null pointer check.
  • String changes made/needed:
  • Is Android affected?: Yes
Flags: needinfo?(stransky)
Attachment #9318405 - Flags: approval-mozilla-beta?

Comment on attachment 9318405 [details]
Bug 1817419 [Linux] Make XULPopupElement::IsWaylandDragSource() more robust r?emilio

Approved for 111.0b5

Attachment #9318405 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: