Closed Bug 1818356 Opened 2 years ago Closed 2 years ago

--panel-description-color is currently using system color GrayText reserved for disabled items only

Categories

(Firefox :: Theme, defect, P2)

Desktop
Unspecified
defect

Tracking

()

RESOLVED FIXED
113 Branch
Accessibility Severity s3
Tracking Status
firefox113 --- fixed

People

(Reporter: jules, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

global-shared.css currently sets --panel-description-color to GrayText. Accessibility recommends we reserve GrayText for disabled or placeholder items only.

Keywords: access
Whiteboard: [access-s3]

Hey Jules, do you have a recommendation for what color we should use here instead?

Flags: needinfo?(jules)

Hey Amy, last time I spoke to Dao about this he recommended inherit since panels already have a color set. Thanks for asking, I forgot to include that.

Flags: needinfo?(jules)

Looks like we use GreyText and a hsl grey hsl(0,0%,50%); for MacOS. I assume we want to update both? (By removing the MacOS override)
Assigning P2 to this - its a simple patch and a11y issue we should get to sooner rather than later.

Severity: -- → S3
Flags: needinfo?(dao+bmo)
Priority: -- → P2

Thanks, Sam. Yes, we should update both places.

(In reply to Sam Foster [:sfoster] (he/him) from comment #3)

Looks like we use GreyText and a hsl grey hsl(0,0%,50%); for MacOS. I assume we want to update both? (By removing the MacOS override)
Assigning P2 to this - its a simple patch and a11y issue we should get to sooner rather than later.

Yeah, we should use something like color-mix(in srgb, currentColor 70%, transparent) instead of GrayText on all platforms when not in HCM, and inherit in HCM.

Flags: needinfo?(dao+bmo)
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/24f45b99ed08 Clean up --panel-description-color and --panel-disabled-color. r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Blocks: 1831642
Accessibility Severity: --- → s3
Whiteboard: [access-s3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: