Nested image-set funcs should fail to parse
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | fixed |
People
(Reporter: canadahonk, Assigned: canadahonk)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
image-set() should not be parsed correctly when nested.
Example invalid value: image-set(image-set(url(example.png)) 2x)
WPT tests (2 currently fail): https://github.com/web-platform-tests/wpt/blob/a2154e3f971f3630643741206ce02bbbc5f31d6f/css/css-images/image-set/image-set-parsing.html#L223-L239
Spec quote (from https://www.w3.org/TR/css-images-4/#image-set-notation):
The
image-set()function can not be nested inside of itself, either directly or indirectly (as an argument to another <image> type).
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
Nested image-set CSS functions should fail to parse as per spec.
WPT tests (2 newly pass):
https://github.com/web-platform-tests/wpt/blob/a2154e3f971f3630643741206ce02bbbc5f31d6f/css/css-images/image-set/image-set-parsing.html#L223-L239
|
||
Updated•2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a154633506f0 Fix parsing nested image-set funcs as valid r=layout-reviewers,emilio
|
||
Comment 3•2 years ago
|
||
Backed out for causing several mochitest plain failures.
Failure logs:
- https://treeherder.mozilla.org/logviewer?job_id=406947425&repo=autoland
- https://treeherder.mozilla.org/logviewer?job_id=406946660&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/642b99e47ec7418e22cfaff5fa3fb06adcf1ff2d
|
|
Assignee | |
Comment 4•2 years ago
|
||
Looks like previous internal tests were incorrect (?), didn't catch those. Need adjusting, will do. Apologies.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ad709052e86e Fix parsing nested image-set funcs as valid r=layout-reviewers,emilio
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
Description
•