Open
Bug 1818830
Opened 2 years ago
Updated 2 years ago
escape() from react-dom seems slower in SM than V8 and JSC
Categories
(Core :: JavaScript Engine, enhancement, P1)
Core
JavaScript Engine
Tracking
()
NEW
People
(Reporter: jrmuizel, Assigned: dthayer)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sp3])
Attachments
(1 file)
|
(deleted),
application/x-javascript
|
Details |
escape:
function escape(key) {
var escaperLookup = {
"=": "=0",
":": "=2"
};
return "$" + ("" + key).replace(/[=:]/g, function(match) {
return escaperLookup[match];
});
}
On the attached benchmark I get:
SM w/ spectre-mitigations off: 38ms
V8: 25ms
JSC: 38ms
The keys used in the benchmark are taken from react-todoMVC
|
Reporter | |
Comment 1•2 years ago
|
||
SM profile: https://share.firefox.dev/3ZgPeYc
V8 profile: https://share.firefox.dev/3Z0gCdo
|
|
Reporter | |
Comment 2•2 years ago
|
||
JSC profile: https://share.firefox.dev/3xQh3eh
|
||
Updated•2 years ago
|
Whiteboard: [sp3]
|
||
Updated•2 years ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-26
|
Assignee | |
Comment 3•2 years ago
|
||
Assigning myself just because I am working on a patch that will indirectly fix this.
Assignee: nobody → dothayer
|
||
Updated•2 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•