Rework socket arrays to eliminate manual array management
Categories
(Core :: Networking, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: jesup, Assigned: jesup)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The socket arrays in nsSocketTransportService are manually managed, which increases the chances of mistakes and makes the code fragile and hard to modify or reason about. This is some of the oldest code in gecko.
Switching them to nsTArrays would be a win.
One thing to avoid performance issues is easy ways to find out if a SocketContext* is a member of an array, or to find the index of so it can be removed in O(1). Implementing a SockIndex() function can solve this.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
|
Assignee | |
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
|
||
Comment 4•2 years ago
|
||
Backed out for causing leakcheck/assertion failures
Push with failures - wpt
Push with failures - Wr
Failure log - wpt
Failure log - Wr
Bug 1822739 seems to be the same underlying issue.
|
||
Comment 5•2 years ago
|
||
Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/11e6330ee008
|
|
||
Comment 7•2 years ago
|
||
Backed out for causing xpcshell failures in dom/base/test/unit_ipc/*
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-TIMEOUT | dom/base/test/unit_ipc/test_bug553888_wrap.js | Test timed out
|
||
Comment 9•2 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•2 years ago
|
Description
•