Closed Bug 1819116 Opened 2 years ago Closed 2 years ago

In system dark mode, minimonth header buttons have double border and not enough contrast

Categories

(Calendar :: Calendar Frontend, defect)

Thunderbird 112
defect

Tracking

(thunderbird_esr102 unaffected, thunderbird111? affected, thunderbird112? affected)

RESOLVED FIXED
112 Branch
Tracking Status
thunderbird_esr102 --- unaffected
thunderbird111 ? affected
thunderbird112 ? affected

People

(Reporter: elizabeth, Assigned: elizabeth)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

This affects Linux and Windows.

@michailbery first found this bug on Linux during review of patch D168853 for bug 1804488. He wrote: "In dark mode on Linux when hovering over the buttons you get a kinda double border and no hover highlight color."

In Windows with a system dark theme and Thunderbird inheriting the theme, the button hover background doesn't change and all that is seen is a very slight color change in the border. This is not enough contrast change.

Expected behavior:

  • On hover, the button should have a background color change
  • On hover, the button should have a single border
  • On hover, the border, larger container background, and button background should be enough color contrast to distinguish between the button and its containing element

Work so far:
@aleca suggested a change in patch D168853, but applying this change affected Windows system light theme with Thunderbird set to a dark theme.

Patch D170954 began to address a solution by aligning the styling of the minimonth header to match how widgets.css buttons work (in terms of hover colors).

Planned work:
Patch D170954 will be moved to this bug from bug 1804488.

In dark mode, adjust hover color

Attachment #9320052 - Attachment is obsolete: true
Attachment #9320362 - Attachment description: WIP: Bug 1819116 - Adjust hover color of minimonth header buttons → Bug 1819116 - Adjust hover on minimonth header buttons. r=micahilbery,aleca,#thunderbird-front-end-reviewers
Attachment #9320362 - Attachment description: Bug 1819116 - Adjust hover on minimonth header buttons. r=micahilbery,aleca,#thunderbird-front-end-reviewers → Bug 1819116 - Adjust hover on minimonth header buttons. r=aleca
OS: Linux → Unspecified

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/5fe69dce08f8
Adjust hover on minimonth header buttons. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: