Closed
Bug 1819898
Opened 2 years ago
Closed 2 years ago
Use internal content policy types for determining IsUpgradableDisplayType
Categories
(Core :: DOM: Security, task, P3)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
112 Branch
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | fixed |
People
(Reporter: freddy, Assigned: ckerschb)
References
(Blocks 1 open bug)
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Looks like we use the external contentpolicytype and the internal contentpolicytype interchangeably.
For a more robust implementation, more consistency would be reasonable.
The "is upgradable display type" check looks at the external IMAGE and MEDIA types (https://searchfox.org/mozilla-central/rev/f7edb0b474a1a922f3285107620e802c6e19914d/dom/base/nsContentUtils.cpp#8647-8651), but that also includes <track>?
Our telemetry seems to have looked at the internal content policy type which is more detailed
Further breadcrumbs:
https://searchfox.org/mozilla-central/rev/f7edb0b474a1a922f3285107620e802c6e19914d/dom/security/nsMixedContentBlocker.cpp#757-763
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → ckerschb
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-active]
|
|
Assignee | |
Updated•2 years ago
|
Summary: Use and track the correct contentpolicytypes in mixed-content blocking → Use internal content policy types for determining IsUpgradableDisplayType
|
|
Assignee | |
Comment 1•2 years ago
|
||
Pushed by mozilla@christophkerschbaumer.com:
https://hg.mozilla.org/integration/autoland/rev/5804b3277416
Use internal content policy types for determining IsUpgradableDisplayType, r=freddyb
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox112:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•