[wpt-sync] Sync PR 38817 - CSSTransitionDiscrete: Fix counter related crashes
Categories
(Core :: Layout: Generated Content, Lists, and Counters, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 38817 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/38817
Details from upstream follow.
Joey Arhar <jarhar@chromium.org> wrote:
CSSTransitionDiscrete: Fix counter related crashes
The generated code in CounterIncrement::ApplyValue expects to receive a
CSSValueList with a CSSValuePair inside of it, so this patch adds a
CSSValuePair to ComputedStyleUtils::ValueForCounterDirectivesBug: 1399631, 1413556
Change-Id: If38d51d026965b2f481a9ed6432ce519587847efReviewed-on: https://chromium-review.googlesource.com/4310132
WPT-Export-Revision: e350e2dcceeb1928ebf42747dfda70204403ce63
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
Assignee | ||
Comment 3•2 years ago
|
||
Assignee | ||
Comment 4•2 years ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 155 subtests
Status Summary
Firefox
OK
: 1
PASS
: 125[GitHub] 140[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt]
FAIL
: 15
Chrome
OK
: 1
PASS
: 125
FAIL
: 15
Safari
OK
: 1
PASS
: 100
FAIL
: 40
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-lists/css-lists-no-interpolation.html [wpt.fyi]
- CSS Transitions: property <counter-increment> from [initial] to [add 123] at (-0.3) should be [initial]:
FAIL
(Chrome:FAIL
, Safari:FAIL
) - CSS Transitions: property <counter-increment> from [initial] to [add 123] at (0) should be [initial]:
FAIL
(Chrome:FAIL
, Safari:FAIL
) - CSS Transitions: property <counter-increment> from [initial] to [add 123] at (0.3) should be [initial]:
FAIL
(Chrome:FAIL
, Safari:FAIL
) - CSS Transitions: property <counter-reset> from [initial] to [add 123] at (-0.3) should be [initial]:
FAIL
(Chrome:FAIL
, Safari:FAIL
) - CSS Transitions: property <counter-reset> from [initial] to [add 123] at (0) should be [initial]:
FAIL
(Chrome:FAIL
, Safari:FAIL
) - CSS Transitions: property <counter-reset> from [initial] to [add 123] at (0.3) should be [initial]:
FAIL
(Chrome:FAIL
, Safari:FAIL
) - CSS Transitions: property <counter-set> from [initial] to [add 123] at (-0.3) should be [initial]:
FAIL
(Chrome:FAIL
, Safari:FAIL
) - CSS Transitions: property <counter-set> from [initial] to [add 123] at (0) should be [initial]:
FAIL
(Chrome:FAIL
, Safari:FAIL
) - CSS Transitions: property <counter-set> from [initial] to [add 123] at (0.3) should be [initial]:
FAIL
(Chrome:FAIL
, Safari:FAIL
) - CSS Transitions: property <list-style-position> from [initial] to [inside] at (-0.3) should be [initial]:
FAIL
(Chrome:FAIL
, Safari:FAIL
) - CSS Transitions: property <list-style-position> from [initial] to [inside] at (0) should be [initial]:
FAIL
(Chrome:FAIL
, Safari:FAIL
) - CSS Transitions: property <list-style-position> from [initial] to [inside] at (0.3) should be [initial]:
FAIL
(Chrome:FAIL
, Safari:FAIL
) - CSS Transitions: property <list-style-type> from [initial] to [square] at (-0.3) should be [initial]:
FAIL
(Chrome:FAIL
, Safari:FAIL
) - CSS Transitions: property <list-style-type> from [initial] to [square] at (0) should be [initial]:
FAIL
(Chrome:FAIL
, Safari:FAIL
) - CSS Transitions: property <list-style-type> from [initial] to [square] at (0.3) should be [initial]:
FAIL
(Chrome:FAIL
, Safari:FAIL
)
- CSS Transitions: property <counter-increment> from [initial] to [add 123] at (-0.3) should be [initial]:
Comment 6•2 years ago
|
||
bugherder |
Description
•