Closed Bug 1820644 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 38830 - Reland "Reject Web Serial requests with an opaque origin"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox113 fixed)

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38830 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38830
Details from upstream follow.

Jack Hsieh <chengweih@chromium.org> wrote:

Reland "Reject Web Serial requests with an opaque origin"

This reverts commit cd2f352906cbfa254100390271e51e9890ed2bbe.

Reason for revert: The fixed parent CL https://chromium-review.googlesource.com/c/chromium/src/+/4307819 is re-landed.

Original change's description:

Revert "Reject Web Serial requests with an opaque origin"

Revert submission 4112689

Reason for revert: suspect for introducing test failures for
DedicatedWorkerTest.TopLevelFrameSecurityOrigin, for example
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-ubsan-vptr/21391/overview

Reverted changes: /q/submissionid:4112689

Change-Id: I496ec21cc6a6e39dd3c2943b8fc7ce3d179a1f73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4307114
Owners-Override: Mikel Astiz \<mastiz@google.com>
Commit-Queue: Mikel Astiz \<mastiz@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1112768}

Change-Id: Ic3f4fe58a946b53a23dfba57d30ee889ec3cc359

Reviewed-on: https://chromium-review.googlesource.com/4311852
WPT-Export-Revision: cfbc1d22608d50eee41e5e35c170f8a8fd24bbbb

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL : 2
TIMEOUT: 3
ERROR : 1

Chrome

OK : 3
PASS : 2
FAIL : 1
TIMEOUT: 1
ERROR : 1

Safari

OK : 2
FAIL : 2
TIMEOUT: 3
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /serial/getPorts/reject_opaque_origin.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • Calls to Serial APIs from an origin with opaque top origin get blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /serial/getPorts/sandboxed_iframe.https.window.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
    • GetPorts from a sandboxed iframe is valid.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
  • /serial/requestPort/reject_opaque_origin.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • Calls to Serial APIs from an origin with opaque top origin get blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • /serial/requestPort/sandboxed_iframe.https.window.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: ERROR, Safari: ERROR)
    • RequestPort from a sandboxed iframe is valid.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)

Tests Disabled in Gecko Infrastructure

  • /serial/getPorts/reject_opaque_origin.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • /serial/getPorts/sandboxed_iframe.https.window.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
  • /serial/requestPort/reject_opaque_origin.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • /serial/requestPort/sandboxed_iframe.https.window.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: ERROR, Safari: ERROR)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2fbf672b92a6 [wpt PR 38830] - Reland "Reject Web Serial requests with an opaque origin", a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.