Closed Bug 1820654 Opened 2 years ago Closed 2 years ago

Replace the label link under "manualUpdate" with html:a element

Categories

(Firefox :: Settings UI, task, P3)

task

Tracking

()

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: tgiles, Assigned: anayocrescent2, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=html])

Attachments

(2 files, 1 obsolete file)

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help.
    This will tell others that you're working on the next steps.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
    • You can also read the Developer Guide, which has answers to most development questions.
  3. Start working on this bug.
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
  4. Build your change with mach build and verify your changes by making sure the link navigates correctly to "https://nightly.mozilla.org". Also check your changes for adherence to our style guidelines by using mach lint.
  5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll push it to autoland.

please can you assign this to me

Hi Tim, I am looking into this bug and interested in working on the next steps.

I will like to work on this bug

Flags: needinfo?(tgiles)

Can I work on this issue?

Assignee: nobody → brownboy3047
Status: NEW → ASSIGNED
Flags: needinfo?(tgiles)

Depends on D173408

please the assignee said i should work on this

this bug is pushing me around unexpectedly , i have figured out the necessary changes thanks to help from @aria, but there is changing ftl label to html is passing build and leaving it as label also result in manualUpdate not working as expected,

I would appreciate if the reviewer can look into it.

Assignee: brownboy3047 → anayocrescent2
Attachment #9327700 - Attachment description: WIP: Bug 1820654 - Replace the label link under manualUpdate with html element. r?tgiles → Bug 1820654 - Replace the label link under manualUpdate with html element. r?tgiles

Depends on D175011

Pushed by tgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/753a6e3c83e1 Replace the label link under manualUpdate with html element. r=tgiles,flod https://hg.mozilla.org/integration/autoland/rev/27155fbfd0e5 Migrate string after changing markup in string. r=flod

Backed out for causing bc failures on browser_aboutPrefs_fc_check_cantApply.js

Backout link

Push with failures

Failure log

Flags: needinfo?(anayocrescent2)

redirecting NI as a reminder to fix this, seems a bit out of scope for good-first-bug

Flags: needinfo?(anayocrescent2) → needinfo?(tgiles)
Pushed by tgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d006951e2b2 Replace the label link under manualUpdate with html element. r=tgiles,flod,application-update-reviewers,bytesized https://hg.mozilla.org/integration/autoland/rev/d9887594633c Migrate string after changing markup in string. r=flod
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
Flags: needinfo?(tgiles)
Attachment #9325031 - Attachment is obsolete: true
Regressions: 1835561
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: