Closed Bug 1820760 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 38848 - [scroll-timeline] Handle reset-only properties in serialization

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox113 fixed)

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38848 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38848
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[scroll-timeline] Handle reset-only properties in serialization

The 'animation' shorthand is supposed to "reset" (i.e. apply the
initial value) of new animation-* longhands. This means that the
shorthand can't represent situations where those longhands have non-
initial values. Return an empty string in those cases.

Note that this does not affect animation-delay-start: the shorthand
can represent that because it's basically just a rename of the
existing animation-delay longhand.

Bug: 1408680
Change-Id: I229c8c471db2b781ec987f2104d627bffbd17348

Reviewed-on: https://chromium-review.googlesource.com/4304005
WPT-Export-Revision: 90917ed72e705fb84f5f762865b5a9c23dce1acd

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 21 subtests

Status Summary

Firefox

OK : 1
PASS: 15[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 16[GitHub]
FAIL: 5[GitHub] 6[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt]

Chrome

OK : 1
PASS: 17
FAIL: 4

Safari

OK : 1
PASS: 16
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /scroll-animations/css/animation-shorthand.html [wpt.fyi]
    • e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim scroll()" should not set the property value: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], PASS [GitHub] (Chrome: PASS, Safari: PASS)
    • e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim timeline" should not set the property value: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], PASS [GitHub] (Chrome: PASS, Safari: PASS)
    • e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n 1s linear 1s 2 reverse forwards paused anim2,\n 1s linear 1s 2 reverse forwards paused anim3" should set animation-timeline: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
    • Animation shorthand can not represent non-initial timelines (specified): FAIL (Chrome: FAIL, Safari: FAIL)
    • Animation shorthand can not represent non-initial timelines (computed): FAIL (Chrome: FAIL, Safari: FAIL)
    • Animation shorthand can not represent non-initial animation-delay-end (specified): FAIL (Chrome: FAIL, Safari: FAIL)
    • Animation shorthand can not represent non-initial animation-delay-end (computed): FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8e8cde82d3bd [wpt PR 38848] - [scroll-animations] Handle reset-only properties in serialization, a=testonly https://hg.mozilla.org/integration/autoland/rev/e55b537a60c4 [wpt PR 38848] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8e8cde82d3bd
https://hg.mozilla.org/mozilla-central/rev/e55b537a60c4

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.