convert .ini manifests to .toml
Categories
(Testing :: General, task)
Tracking
(firefox118 fixed)
Tracking | Status | |
---|---|---|
firefox118 | --- | fixed |
People
(Reporter: jmaher, Assigned: tmarble)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 3 obsolete files)
(deleted),
text/x-phabricator-request
|
Details |
this should be able to be scripted, I imagine some steps would be:
- read in .ini files, hack write them out; whatever doesn't match (specifically comments aligning with the wrong section) needs attention
- read .ini, write .toml, ensure read+write .toml files are identical
- read .toml, hack write .ini, diff what is different, should be same as #1;
- manually edit the differences
- for .toml files, write them out in alphanumeric sorted order for the test cases
there will be some cases that need to be handled differently, I imagine:
- relative path manifests (like include ../blah/blah.ini)
- tools that generate/copy .ini files
- probably others I cannot think of right now
The end result of this patch will be for most mochitest.ini
, browser.ini
, chrome.ini
, xpcshell.ini
we will rename them to *.toml
and have them edited in proper .toml format.
Updated•1 year ago
|
Comment 1•1 year ago
|
||
I filed a bug to do the same on comm-central, so you can let us know when we need to do something.
Assignee | ||
Comment 2•1 year ago
|
||
Updated•1 year ago
|
Assignee | ||
Comment 3•1 year ago
|
||
Updated•1 year ago
|
Assignee | ||
Comment 4•1 year ago
|
||
Updates manifestparser tests to explicity set use_toml
Updated•1 year ago
|
Comment 6•1 year ago
|
||
Backed out for causing manifest.ini related build bustages.
- Backout link
- Push with failures
- Failure Log
- Failure line: KeyError: '/builds/worker/checkouts/gecko/testing/mozbase/manifestparser/tests/manifest.ini'
Assignee | ||
Comment 7•1 year ago
|
||
Backout is okay -- KeyError fix coming in a future patch (for Bug 1821207)
Assignee | ||
Comment 8•1 year ago
|
||
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Comment 10•1 year ago
|
||
bugherder |
Comment 11•1 year ago
|
||
This now logs for every manifest read. E.g. executing ./mach addtest
reads a test manifest, running ./mach build
in some circumstances reads a lot of test manifests... was that intentional?
Assignee | ||
Comment 12•1 year ago
|
||
Yes this is intentional. The amount of manifest reading has not changed, however during the transition (Bug 1821199) we use this log verbosity to ensure that ManifestParser is reading the new TOML manifests.
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Description
•