Closed Bug 1821207 Opened 2 years ago Closed 1 year ago

convert .ini manifests to .toml

Categories

(Testing :: General, task)

Default
task

Tracking

(firefox118 fixed)

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: jmaher, Assigned: tmarble)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

this should be able to be scripted, I imagine some steps would be:

  1. read in .ini files, hack write them out; whatever doesn't match (specifically comments aligning with the wrong section) needs attention
  2. read .ini, write .toml, ensure read+write .toml files are identical
  3. read .toml, hack write .ini, diff what is different, should be same as #1;
  4. manually edit the differences
  5. for .toml files, write them out in alphanumeric sorted order for the test cases

there will be some cases that need to be handled differently, I imagine:

  • relative path manifests (like include ../blah/blah.ini)
  • tools that generate/copy .ini files
  • probably others I cannot think of right now

The end result of this patch will be for most mochitest.ini, browser.ini, chrome.ini, xpcshell.ini we will rename them to *.toml and have them edited in proper .toml format.

I filed a bug to do the same on comm-central, so you can let us know when we need to do something.

Assignee: nobody → tmarble
Status: NEW → ASSIGNED
Attachment #9346740 - Attachment description: Bug 1821207 - convert .ini manifests to .toml (partial) r=jmaher → Bug 1821207 - convert .ini manifests to .toml (partial) r=jmaher!

Updates manifestparser tests to explicity set use_toml

Attachment #9346740 - Attachment description: Bug 1821207 - convert .ini manifests to .toml (partial) r=jmaher! → Bug 1821207 - convert .ini manifests to .toml (partial) r=jmaher
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3dd53f46f9eb convert .ini manifests to .toml (partial) r=jmaher

Backed out for causing manifest.ini related build bustages.

Flags: needinfo?(tmarble)

Backout is okay -- KeyError fix coming in a future patch (for Bug 1821207)

Attachment #9346967 - Attachment is obsolete: true
Attachment #9346740 - Attachment is obsolete: true
Attachment #9346565 - Attachment is obsolete: true
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec48256d007f convert .ini manifests to .toml (partial + batch 1) r=jmaher
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch

This now logs for every manifest read. E.g. executing ./mach addtest reads a test manifest, running ./mach build in some circumstances reads a lot of test manifests... was that intentional?

Yes this is intentional. The amount of manifest reading has not changed, however during the transition (Bug 1821199) we use this log verbosity to ensure that ManifestParser is reading the new TOML manifests.

Flags: needinfo?(tmarble)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: