Closed
Bug 1821375
Opened 2 years ago
Closed 2 years ago
Remove weird providerName != "UrlbarProviderTopSites" check from UrlbarController::typeFromElement
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
112 Branch
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [snt-urlbar-result-menu])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
I don't understand why we're guarding this code with that providerName != "UrlbarProviderTopSites" check: https://hg.mozilla.org/integration/autoland/rev/4e06f5ee4dd4#l2.65
This doesn't seem useful in any way. The line goes back to https://hg.mozilla.org/mozilla-central/rev/74ed02c503d16d2b9fc21072d1ef949697485aba#l1.207 but it didn't even seem useful back then.
|
||
Updated•2 years ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SNT-557
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8aea0e783414
Remove weird providerName != "UrlbarProviderTopSites" check from UrlbarController::typeFromElement. r=mak
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox112:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•