Closed Bug 1821951 Opened 2 years ago Closed 1 years ago

[CTW] Remove HyperTextAccessible methods that call HyperTextAccessibleBase

Categories

(Core :: Disability Access APIs, task)

task

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: Jamie, Assigned: Jamie)

References

(Blocks 1 open bug)

Details

(Whiteboard: [ctw-postship])

Attachments

(2 files)

There are several methods in HyperTextAccessible which delegate to HyperTextAccessibleBase if the cache is enabled. These include TextAtOffset, TextBeforeOffset, TextAfterOffset and Attributes, but there'll probably be others before we get to this. There are also helper methods that these depend on that aren't used by anything else; e.g. FindOffset, FindLineBoundary, FindWordBoundary, FindParagraphStart/EndOffset. Once we're ready to remove the legacy implementation, we should just remove these methods altogether. This also means they no longer need to be virtual in HyperTextAccessibleBase.

Depends on: 1821955

Note that bug 1384606 will implement a PeekOffset flag that is now only needed for HyperTextAccessible::FindOffset. We should remove that as well.

Assignee: nobody → jteh

This was only added for a11y and a11y no longer needs it.
Note that the code in Mac HyperTextAccessibleWrap which used this is no longer used itself and will be removed in bug 1821965.

Depends on: 1821957
Blocks: 1833313
Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d15074461aeb part 1: Remove HyperTextAccessible methods that are no longer needed now that the cache is always used. r=morgan,taskgraph-reviewers,bhearsum https://hg.mozilla.org/integration/autoland/rev/397196f3998e part 2: Remove PeekOffsetOption::AllowContentInDifferentNativeAnonymousSubtreeRoot. r=eeejay,masayuki,taskgraph-reviewers,bhearsum
Status: NEW → RESOLVED
Closed: 1 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: