Closed Bug 1821999 Opened 2 years ago Closed 2 years ago

"Location" column doesn't show anything for Saved Search Folders (used to show containing folder name)

Categories

(Thunderbird :: Folder and Message Lists, defect)

Thunderbird 111
defect

Tracking

(thunderbird_esr102 unaffected, thunderbird111 wontfix, thunderbird112+ fixed)

VERIFIED FIXED
113 Branch
Tracking Status
thunderbird_esr102 --- unaffected
thunderbird111 --- wontfix
thunderbird112 + fixed

People

(Reporter: eb1, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

(Keywords: regression, useless-UI, Whiteboard: [Supernova3p])

Attachments

(2 files)

Steps to reproduce:

While displaying the email list of a search folder, I added the "Location" column.

Actual results:

"Location" column is always empty

Expected results:

"Location" column shows the folder the email is in (as it used to do in older Thunderbird versions).

Name Thunderbird
Version 111.0b3
Build ID 20230306174148
Distribution ID
Update Channel beta
User Agent Mozilla/5.0 (X11; Linux x86_64; rv:111.0) Gecko/20100101 Thunderbird/111.0
OS Linux 5.19.0-35-generic #36~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Fri Feb 17 15:17:25 UTC 2

Component: Untriaged → Folder and Message Lists
Keywords: regression
Whiteboard: [Supernova]
Status: UNCONFIRMED → NEW
Ever confirmed: true

While displaying the email list of a search folder,

Do you mean a virtual folder/saved search?

Or one of the other search methods, such as Edit > Find > search messages?

Flags: needinfo?(eb1)

This happens for both. This also happens when opening the conversation associated with a message (and in this case, the location column is not there by default).

I meant a virtual folder/saved search. The location column is not shown by default, but when I add it, it remains empty.

In Edit>Find>Search Messages the location column is shown and shows the folders.

To reproduce:

  • Edit>Find>Search Messages
  • Search for messages in: (select account name); Search Subfolders ticked; Match all of the following: Status: isn't: Read
  • Click Search button
  • Location column correctly shows folders
  • Click "Save as Search Folder"
  • Name: Test
  • Click "Create"
  • In left pane, select "Test" folder
  • Add Location column
    --> Location column stays empty.
Flags: needinfo?(eb1)

Confirming for 113.0a1 (2023-03-19) (64-bit), Win10.

Still working in 102 for saved search folders, where location column shows the name of the containing folder (which really isn't the full location/path, but that's probably another old bug or shortcoming again).

In fact, location column never shows anything for me even for regular folders, but that might be by design, also in 102 not showing location for plain vanilla folders.

STR

  • Right-click on folder > (Advanced) Search messages...
  • Ensure that multiple folders are searched and have matches (Choose... button to select folders).
  • Define search criteria which generate matches from several folders, then Save as Search folder, New Saved Search folder name: My saved search folder
  • Select My saved search folder in folder list
  • From column picker (right-most of column header), select Location column and look at that column in the message list

Actual

  • Location column of saved search folder shows nothing

Expected

  • Location column of saved search folder should show Folder name (well, at least that's what it does in 102).
Summary: "Location" column doesn't show anything for Search Folders → "Location" column doesn't show anything for Saved Search Folders

Not sure where this is handled, but sn-msglist sounds like a fair start.

Blocks: sn-msglist
Severity: -- → S3
Keywords: useless-UI
Summary: "Location" column doesn't show anything for Saved Search Folders → "Location" column doesn't show anything for Saved Search Folders (used to show containing folder name)

This needed to be copied over from nsMsgSearchDBView::GetCellText, since we can no longer use that method to fill the tree cells.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Target Milestone: --- → 113 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/2f763a58fba3
Fill the Location column if it is shown. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Comment on attachment 9325620 [details]
Bug 1821999 - Fill the Location column if it is shown. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9325620 - Flags: approval-comm-beta+

Thanks. Looks good on daily.

Status: RESOLVED → VERIFIED
Whiteboard: [Supernova] → [Supernova3p]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: