Closed
Bug 1822012
Opened 2 years ago
Closed 2 years ago
Convert toolkit/components/xulstore to ES modules
Categories
(Toolkit :: Startup and Profile System, task)
Toolkit
Startup and Profile System
Tracking
()
RESOLVED
FIXED
113 Branch
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: standard8, Assigned: osuolale49, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [esmification-timeline][lang=js])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it - please respect other contributors comments as well. You'll be automatically assigned when you upload the first patches.
Here's what to do:
- Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
- If you need help setting up, ask in #introduction on Matrix
- Using the ESMification walkthrough as a guide:
- Run
./mach esmify --convert path/to/files
- Examine the output for any errors from ESLint and fix them.
- Next convert the imports -
./mach esmify --import . --prefix path/to/files
- Again, check for any errors and fix them.
- Run a build to check it passes.
- Also run
./mach eslint --fix path/to/files
and check there are no raised failures - Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
- Run
- Use
moz-phab submit
to submit the patches for review.
Assignee | ||
Comment 1•2 years ago
|
||
Hi, I am currently working on it
Assignee | ||
Comment 2•2 years ago
|
||
Updated•2 years ago
|
Assignee: nobody → osuolale49
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c3e9356fdd3
Convert toolkit/components/xulstore to ES modules. r=Standard8
Comment 4•2 years ago
|
||
Backed out 2 changesets (Bug 1821927, Bug 1822012) for causing failures in browser_startup.js CLOSED TREE
Log: https://treeherder.mozilla.org/logviewer?job_id=408836224&repo=autoland&lineNumber=5769
Backout: https://hg.mozilla.org/integration/autoland/rev/1295e912f414beb2b3919719bc8088a73bd26e32
Flags: needinfo?(osuolale49)
Reporter | ||
Updated•2 years ago
|
Flags: needinfo?(osuolale49)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/afdee7d6498a
Convert toolkit/components/xulstore to ES modules. r=Standard8
Comment 6•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•