Closed Bug 1822112 Opened 2 years ago Closed 2 years ago

"WebDriver:GetComputedRole" should return WAI-ARIA roles

Categories

(Remote Protocol :: Marionette, defect, P3)

Product:
Remote Protocol
Component:
Marionette
Type:
defect
Points:
1

Tracking

(firefox114 fixed)

Status:
RESOLVED FIXED
Milestone:
114 Branch
Tracking Flags:
Tracking Status
firefox114 --- fixed

People

(Reporter: jdescottes, Assigned: Jamie)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webdriver:m7][webdriver:external][webdriver:relnote])

Attachments

(1 file, 1 obsolete file)

Bug 1822112: Make Marionette/WebDriver getComputedRole return standardized ARIA role names.
(deleted), text/x-phabricator-request
Details

As discussed at https://phabricator.services.mozilla.com/D172146#5666525, currently the Accessibility Service APIs used by Marionette do not return WAI-ARIA roles. In order to be used for cross browser tests, we should have a way to retrieve the computed WAI-ARIA role.

For now this leads to 2 wdspec test failures:

  • [test_computed_roles[<input role=searchbox>-input-searchbox]]
  • [test_computed_roles[<img role=presentation>-img-presentation]]

Setting need-info for James based on the questions from: https://phabricator.services.mozilla.com/D172146#5668324

Flags: needinfo?(jteh)

I just replied in Phab.

Flags: needinfo?(jteh)

We could just use this bug for the a11y engine change if you like. I'm happy either way.

(In reply to James Teh [:Jamie] from comment #3)

We could just use this bug for the a11y engine change if you like. I'm happy either way.

If the API will change I think it would be good to have a separate bug. Then we can use this bug for the necessary changes in Marionette and for adding potential new webdriver tests.

James would you mind filing the a11y related bug and mark it as blocker for this one? Thanks!

Flags: needinfo?(jteh)
Depends on: 1824935
Flags: needinfo?(jteh)
Points: --- → 1
Priority: -- → P3
Whiteboard: [webdriver:backlog]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(hskupin)

(In reply to Julian Descottes [:jdescottes] from comment #0)

  • [test_computed_roles[<img role=presentation>-img-presentation]]

I don't understand this test. I've commented on the (merged) PR asking for clarifcation; see https://github.com/web-platform-tests/wpt/pull/23793/files#r1168123033.

Assignee: nobody → jteh
Status: NEW → ASSIGNED
Blocks: 1828600

Bug 1827934 added support for the web-platform-tests here. We see some failures in testing/web-platform/tests/accname/basic.html which seem likely to be this bug. There are also some failures in testing/web-platform/tests/wai-aria/role/ which are probably this bug, but I'm not sure. Also, testing/web-platform/tests/wai-aria/role/roles.html has some tests that are intermittent. I haven't investigated deeply, but I wonder if it's possible we're not always waiting for the a11y tree to be ready, or something? Locally when the tests fail we seem to get null rather than a string role. Maybe that should be a separate bug?

(In reply to James Graham [:jgraham] from comment #9)

Bug 1827934 added support for the web-platform-tests here. We see some failures in testing/web-platform/tests/accname/basic.html which seem likely to be this bug.

There are no more failures in accname after your patch in Bug 1827934, so I guess you meant to only talk about the tests in wai-aria/role? accname tests will most likely not be impacted by this bug.

You are correct, I copied the wrong basic.html path :) I meant testing/web-platform/tests/wai-aria/role/basic.html

Blocks: 1828816

(In reply to James Graham [:jgraham] from comment #9)

testing/web-platform/tests/wai-aria/role/roles.html has some tests that are intermittent.

I filed bug 1828816 for that.

Blocks: 1829269
Severity: -- → S3
Flags: needinfo?(hskupin)
Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/50324d39e9c1 Make Marionette/WebDriver getComputedRole return standardized ARIA role names. r=jdescottes,webdriver-reviewers
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8886f7011919 fixup: Update computed role in testing/marionette/harness/marionette_harness/tests/unit/test_get_computed_role.py r=fix. CLOSED TREE

Backed out for causing multiple failures.

  • Pushes with failures - mochitests
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | accessible/tests/browser/role/browser_computedARIARole.js | computedARIARole for htmlTbody is correct - Got "group", expected "rowgroup"
Flags: needinfo?(jteh)
Attachment #9330082 - Attachment is obsolete: true
Flags: needinfo?(jteh)
Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d51055276376 Make Marionette/WebDriver getComputedRole return standardized ARIA role names. r=jdescottes,webdriver-reviewers

https://hg.mozilla.org/mozilla-central/rev/d51055276376

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox114: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
Whiteboard: [webdriver:backlog] → [webdriver:m7][webdriver:external][webdriver:relnote]
Summary: getComputedRole should return WAI-ARIA roles → "WebDriver:GetComputedRole" should return WAI-ARIA roles
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: