Fixes to how PHC reports its memory usage
Categories
(Core :: Memory Allocator, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: pbone, Assigned: pbone)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert)
Attachments
(3 files)
PHC adds the sizes of its guard pages and other protected pages to jemalloc_stats_t.waste, which is incorrect since this tracks committed memory and protected pages are uncommitted.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D172655
|
|
Assignee | |
Comment 3•2 years ago
|
||
Depends on D173098
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/42250977529b
https://hg.mozilla.org/mozilla-central/rev/ac5d1057c562
https://hg.mozilla.org/mozilla-central/rev/5c399ec3dae0
|
||
Comment 6•2 years ago
|
||
Backed out for causing Bug 1825467 and busting Thunderbird builds. Unfortunately the patch from https://bugzilla.mozilla.org/show_bug.cgi?id=1825467#c5 didn't hold for asan/tsan builds.
Backout link: https://hg.mozilla.org/integration/autoland/rev/867708a3693788155fdebeba7ae97751c4133a31
|
|
||
Comment 8•2 years ago
|
||
Relanded this because https://phabricator.services.mozilla.com/D174086 was updated to include a fix for asan/tsan bustages. This will reach mozilla-central with the next merge.
|
||
Comment 9•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d977992ff939
https://hg.mozilla.org/mozilla-central/rev/7ea9d1701b91
https://hg.mozilla.org/mozilla-central/rev/fbb6567e3fae
|
||
Comment 10•2 years ago
|
||
(In reply to Pulsebot from comment #4)
Pushed by pbone@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42250977529b
Don't include PHC guard pages in explicit memory r=glandium
https://hg.mozilla.org/integration/autoland/rev/ac5d1057c562
Update a function name in a comment r=glandium
https://hg.mozilla.org/integration/autoland/rev/5c399ec3dae0
Add about:memory entries for PHC r=glandium
== Change summary for alert #37939 (as of Fri, 31 Mar 2023 12:34:48 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 6% | Base Content Explicit | windows11-64-2009-shippable-qr | fission | 8,592,538.67 -> 8,058,709.33 |
| 6% | Base Content Explicit | linux1804-64-shippable-qr | fission | 7,807,642.67 -> 7,347,370.67 |
| 6% | Base Content Explicit | linux1804-64-shippable-qr | fission | 7,803,461.33 -> 7,347,029.33 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=37939
|
|
||
Updated•2 years ago
|
Description
•