Closed Bug 1822931 Opened 2 years ago Closed 2 years ago

Bad signature for a Maybe method

Categories

(Socorro :: Signature, task)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mccr8, Assigned: gsvelto)

References

Details

Attachments

(1 file)

The top frame of this crash is mozilla::Maybe<unsigned long>::value() const& but somehow that got turned into just [@ const], which is not very helpful.

It seems like the actual symbol for this function is mozilla::Maybe<unsigned long>::value() const & (note the space after the const keyword) and this is tripping Socorro's signature generator which expects it to be const& instead of const &. I'll double-check if this is an issue with dump_syms, if it's not then we'll just have to tweak Socorro.

dump_syms is processing the symbol correctly, all the demanglers I tried spit out mozilla::Maybe<unsigned long>::value() const & so we'll have to tweak Socorro. Patch incoming.

Assignee: nobody → gsvelto
Status: NEW → ASSIGNED

(In reply to Andrew McCreight [:mccr8] from comment #0)

The top frame of this crash is mozilla::Maybe<unsigned long>::value() const& but somehow that got turned into just [@ const], which is not very helpful.

It seems to me that this crash used to be bug 1592404 but that its signature has been changed by bug 1791758. So once this patch is through we might need to update also the signature prefix will hopefully see them arrive again there.

I pushed this out just now in bug #1824987. Marking as FIXED.

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: